Bug 1880983 - %pyproject_wheel requires pip
Summary: %pyproject_wheel requires pip
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: pyproject-rpm-macros
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-21 10:49 UTC by Lumír Balhar
Modified: 2020-09-29 02:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-21 12:53:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lumír Balhar 2020-09-21 10:49:33 UTC
Description of problem:
It seems that `%pyproject_wheel` does not support other build systems like flit and requires pip to build a wheel.

Version-Release number of selected component (if applicable):
pyproject-rpm-macros-0-28.fc34

How reproducible:
Always

Steps to Reproduce:
1. Build python-pep517 from source

Actual results:
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.svaSAx
+ umask 022
+ cd /builddir/build/BUILD
+ cd pep517-0.7.0
+ export TMPDIR=/builddir/build/BUILD/pep517-0.7.0/.pyproject-builddir
+ TMPDIR=/builddir/build/BUILD/pep517-0.7.0/.pyproject-builddir
+ mkdir -p /builddir/build/BUILD/pep517-0.7.0/.pyproject-builddir
+ CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection'
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '
+ /usr/bin/python3 -m pip wheel --wheel-dir pyproject-wheeldir --no-deps --use-pep517 --no-build-isolation --disable-pip-version-check --no-clean --progress-bar off --verbose .
/usr/bin/python3: No module named pip

Expected results:
Sucessful build

Comment 1 Miro Hrončok 2020-09-21 11:20:06 UTC
Pyproject macros support various build backends (such as setuptools, flit) but they use pip as the build frontend. Is this an issue for you and if so, why?

Currently, %pyproject_wheel is only supported with %pyproject_buildrequires. %pyproject_buildrequires generates a dependency on pip, sot the error you see is most likely caused by not using %pyproject_buildrequires.

Note that even if %pyproject_wheel somehow builds the wheel without pip, the %pyproject_install macro is a wrapper around pip to install it as well.



python-pep517 source was created when pip was a runtime dependency of pyproject-rpm-macros. I would have fixed the spec file if it was tracked by Kochei, but it wasn't :(

Similar fix in python-tox-current-env: https://src.fedoraproject.org/rpms/python-tox-current-env/c/3e7fdc2f

Comment 2 Miro Hrončok 2020-09-21 12:13:08 UTC
Here's a fix for pep517: https://src.fedoraproject.org/rpms/python-pep517/pull-request/3

Comment 3 Fedora Update System 2020-09-21 12:52:54 UTC
FEDORA-2020-18c162c68b has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2020-09-21 12:52:55 UTC
FEDORA-2020-4461cf5515 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4461cf5515

Comment 5 Miro Hrončok 2020-09-21 13:02:28 UTC
A quick grep reveals that python-pep517 was the only remaining package w/out %pyproject_buildrequires.

Comment 6 Fedora Update System 2020-09-21 14:28:42 UTC
FEDORA-2020-4461cf5515 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4461cf5515`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4461cf5515

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-09-23 15:25:15 UTC
FEDORA-2020-5bace8535f has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-5bace8535f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5bace8535f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-09-27 00:15:51 UTC
FEDORA-2020-5bace8535f has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-09-29 02:21:01 UTC
FEDORA-2020-4461cf5515 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.