Bug 1881026

Description of problem:
I did setup a new Windows VM with its timezone set to "Romance Standard Time"
This timezone is also configured in Windows itself.

But the oVirt UI keeps complaining:
"Actual timezone in the guest differs from the configuration"


How reproducible:
Always :)


Steps to Reproduce:
1. Create VM with "Romance Standard Time"
2. Install windows and set timezone to Europe/Brussels, Europe/Paris (all in the Romance standard time)

Actual results:
You'll have the warning in the UI overview.

Expected results:
I would expect its fine :)

Additional info:
The warning shows up when the following function returns true:
    private static boolean hasDifferentTimezone(VM vm) {
        if (AsyncDataProvider.getInstance().isWindowsOsType(vm.getVmOsId())) {
            String timeZone = vm.getTimeZone();
            if (timeZone != null && !timeZone.isEmpty()) {
                int offset = 0;
                String javaZoneId = null;
                // convert to java & calculate offset
                javaZoneId = WindowsJavaTimezoneMapping.get(timeZone);

                if (javaZoneId != null) {
                    offset = TimeZoneType.GENERAL_TIMEZONE.getStandardOffset(javaZoneId);
                }

                if (vm.getGuestOsTimezoneOffset() != offset) {
                    return true;
                }
            }
        }
        return false;
    }

This will calculate the offset (from UTC) of "(GMT+01:00) Romance Standard Time".
It does this by regex, so +01:00 -> 60mins offset

Now as far as I see getGuestOsTimezoneOffset returns its real offset (including the daylight saving) so it returns 120.

That is also what the DB tells me :)
 utc_diff | guest_timezone_offset 
----------+-----------------------
     7201 |                   120
(1 row)


And as 120 != 60, warning is shown!