Spec URL: http://www.nosuchhost.net/~cheese/temp/freeorion.spec SRPM URL: http://www.nosuchhost.net/~cheese/fedora/packages/32/SRPMS/freeorion-0.4.10-1.fc32.src.rpm Description: freeorion got retired due to using python2 only. This changed with 0.4.10, therefore we want to revive freeorion. Fedora Account System Username: cheese
diff from last version to actual version: http://www.nosuchhost.net/~cheese/temp/freeorion.patch
>Requires: dejavu-sans-fonts >Requires: google-roboto-fonts >[...] >ln -s %{_datadir}/fonts/google-roboto/Roboto-{Regular,Bold}.ttf %{buildroot}%{_datadir}/%{name}/default/data/fonts/ >ln -s %{_datadir}/fonts/dejavu/DejaVuSans{,-Bold}.ttf %{buildroot}%{_datadir}/%{name}/default/data/fonts/ Using hard-coded paths like these is now deprecated in favour of using fc-match. Check this commit for an example on how to modify your spec: https://src.fedoraproject.org/rpms/gravity-beams-and-evaporating-stars/c/cb5b4a95b70e25ca26c1d39e03ee4ef595b561d0
(In reply to Artur Frenszek-Iwicki from comment #2) > >Requires: dejavu-sans-fonts > >Requires: google-roboto-fonts > >[...] > >ln -s %{_datadir}/fonts/google-roboto/Roboto-{Regular,Bold}.ttf %{buildroot}%{_datadir}/%{name}/default/data/fonts/ > >ln -s %{_datadir}/fonts/dejavu/DejaVuSans{,-Bold}.ttf %{buildroot}%{_datadir}/%{name}/default/data/fonts/ > Using hard-coded paths like these is now deprecated in favour of using > fc-match. > Check this commit for an example on how to modify your spec: > https://src.fedoraproject.org/rpms/gravity-beams-and-evaporating-stars/c/ > cb5b4a95b70e25ca26c1d39e03ee4ef595b561d0 new Spec URL: http://www.nosuchhost.net/~cheese/temp/freeorion.spec SRPM URL (currently uploading): http://www.nosuchhost.net/~cheese/fedora/packages/32/SRPMS/freeorion-0.4.10-2.fc32.src.rpm
*** Bug 1738008 has been marked as a duplicate of this bug. ***
Have you tried building on both rawhide and fedora-33-x86_64? I see CMake errors when building for fedora-33.
I'm also not able to build the RPM on Fedora 32. > {standard input}: Assembler messages: > {standard input}:1912378: Warning: end of file not at end of a line; newline inserted > c++: fatal error: Killed signal terminated program cc1plus
I built only with fedora32. The build needs lots of memory. I had to build in serial to get a valid rpm without oom-errors. Will give it a try with rawhide and 33 soon.
ah. there are problems with the new boost. will take some time to figure that out. i think there is a patch upstream addressing that problem.
(In reply to josef radinger from comment #7) > I built only with fedora32. The build needs lots of memory. I had to build > in serial to get a valid rpm without oom-errors. > Will give it a try with rawhide and 33 soon. I'm sure this was the problem. I tried building it in a VM and likely haven't allocated enough RAM to the VM.
Rebuild with patch from upstream is underway. f 33 has a new version of boost and that broke the build besides your oom. As my buildsystem is rather slow this will last until tomorrow. Will get back as soon I get a successful build (fc33 looks good, rawhide still unknown)
builds now on f32, f33 and rawhide on architecture x86_64. aarch64 build is still underway (i have a very slow emulation). new Spec URL: http://www.nosuchhost.net/~cheese/temp/freeorion.spec new SRPM URL: http://www.nosuchhost.net/~cheese/temp/freeorion-0.4.10-4.src.rpm
The license check found a few additional licenses that are included in the source distribution. Let's add those to the License field: - Boost Software License 1.0 - zlib/libpng license - BSD 3-clause "New" or "Revised" License Should the freeorion-data subpackage Require: the %fonts rather than the freeorion package, since the -data subpackage is the one containing the symlinks? Full Package Review follows: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/freeorion See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [*]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License Creative Commons Attribution-ShareAlike 3.0 Unported License", "GNU Lesser General Public License (v2.1 or later)", "GPL (v2 or later)", "BSD 3-clause "New" or "Revised" License", "GPL (v2) GNU Lesser General Public License", "zlib/libpng license GNU Lesser General Public License (v2.1 or later)", "Boost Software License 1.0", "*No copyright* Public domain", "zlib/libpng license", "*No copyright* zlib/libpng license". 3555 files have unknown license. Detailed output of licensecheck in /home/link/1881183-freeorion/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [*]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in freeorion-data [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: freeorion-0.4.10-4.fc34.x86_64.rpm freeorion-data-0.4.10-4.fc34.noarch.rpm freeorion-debuginfo-0.4.10-4.fc34.x86_64.rpm freeorion-debugsource-0.4.10-4.fc34.x86_64.rpm freeorion-0.4.10-4.fc34.src.rpm freeorion.x86_64: W: no-manual-page-for-binary freeorion freeorion.x86_64: W: no-manual-page-for-binary freeorionca freeorion.x86_64: W: no-manual-page-for-binary freeoriond freeorion-data.noarch: W: no-documentation freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/DejaVuSans-Bold.ttf /usr/share/fonts/dejavu-sans-fonts/DejaVuSans-Bold.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu-sans-fonts/DejaVuSans.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf freeorion-data.noarch: E: zero-length /usr/share/freeorion/default/python/AI/DynamicResearchAI.py freeorion-data.noarch: E: non-executable-script /usr/share/freeorion/default/python/common/charting/charts.py 644 /usr/bin/python2 freeorion.src:46: W: mixed-use-of-spaces-and-tabs (spaces: line 46, tab: line 1) 5 packages and 0 specfiles checked; 2 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: freeorion-debuginfo-0.4.10-4.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. freeorion-debugsource.x86_64: W: invalid-url URL: http://freeorion.org <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. freeorion-data.noarch: W: invalid-url URL: http://freeorion.org <urlopen error [Errno -3] Temporary failure in name resolution> freeorion-data.noarch: W: no-documentation freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/DejaVuSans-Bold.ttf /usr/share/fonts/dejavu-sans-fonts/DejaVuSans-Bold.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu-sans-fonts/DejaVuSans.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf freeorion-data.noarch: W: dangling-symlink /usr/share/freeorion/default/data/fonts/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf freeorion-data.noarch: E: zero-length /usr/share/freeorion/default/python/AI/DynamicResearchAI.py freeorion-data.noarch: E: non-executable-script /usr/share/freeorion/default/python/common/charting/charts.py 644 /usr/bin/python2 warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. freeorion.x86_64: W: invalid-url URL: http://freeorion.org <urlopen error [Errno -3] Temporary failure in name resolution> freeorion.x86_64: W: no-manual-page-for-binary freeorion freeorion.x86_64: W: no-manual-page-for-binary freeorionca freeorion.x86_64: W: no-manual-page-for-binary freeoriond freeorion.x86_64: E: invalid-appdata-file /usr/share/appdata/freeorion.appdata.xml warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. freeorion-debuginfo.x86_64: W: invalid-url URL: http://freeorion.org <urlopen error [Errno -3] Temporary failure in name resolution> 4 packages and 0 specfiles checked; 3 errors, 12 warnings. Unversioned so-files -------------------- freeorion: /usr/lib64/freeorion/libGiGi.so freeorion: /usr/lib64/freeorion/libfreeorioncommon.so freeorion: /usr/lib64/freeorion/libfreeorionparse.so Source checksums ---------------- https://github.com/freeorion/freeorion/releases/download/v0.4.10/FreeOrion_v0.4.10_2020-07-10.f3d403e_Source.tar.gz : CHECKSUM(SHA256) this package : e72ab42cba1ee8842507340931ef389e64011e040a4adc74add5f4997bbcba8b CHECKSUM(SHA256) upstream package : e72ab42cba1ee8842507340931ef389e64011e040a4adc74add5f4997bbcba8b Requires -------- freeorion (rpmlib, GLIBC filtered): font(dejavusans) font(roboto) freeorion-data hicolor-icon-theme ld-linux-x86-64.so.2()(64bit) libGL.so.1()(64bit) libGLEW.so.2.1()(64bit) libGiGi.so()(64bit) libSDL2-2.0.so.0()(64bit) libboost_filesystem.so.1.73.0()(64bit) libboost_iostreams.so.1.73.0()(64bit) libboost_locale.so.1.73.0()(64bit) libboost_log.so.1.73.0()(64bit) libboost_log_setup.so.1.73.0()(64bit) libboost_python39.so.1.73.0()(64bit) libboost_regex.so.1.73.0()(64bit) libboost_serialization.so.1.73.0()(64bit) libboost_thread.so.1.73.0()(64bit) libc.so.6()(64bit) libfreeorioncommon.so()(64bit) libfreeorionparse.so()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libpython3.9.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvorbis.so.0()(64bit) libvorbisfile.so.3()(64bit) rtld(GNU_HASH) freeorion-data (rpmlib, GLIBC filtered): freeorion-debuginfo (rpmlib, GLIBC filtered): freeorion-debugsource (rpmlib, GLIBC filtered): Provides -------- freeorion: application() application(org.freeorion.FreeOrion.desktop) freeorion freeorion(x86-64) libGiGi.so()(64bit) libfreeorioncommon.so()(64bit) libfreeorionparse.so()(64bit) metainfo() metainfo(freeorion.appdata.xml) metainfo(org.freeorion.FreeOrion.metainfo.xml) freeorion-data: freeorion-data freeorion-debuginfo: debuginfo(build-id) freeorion-debuginfo freeorion-debuginfo(x86-64) freeorion-debugsource: freeorion-debugsource freeorion-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1881183 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Java, Haskell, R, PHP, fonts, Perl, Python, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
working with upstream to fix small issues
new version: src.rpm: http://www.nosuchhost.net/~cheese/temp/freeorion-0.4.10.1-1.src.rpm spec: http://www.nosuchhost.net/~cheese/temp/freeorion.spec
any more comments/suggestions?
I'm getting some build errors again. fedora-review failed to build the RPM. I imported it into my local dist-git checkout and tried a mockbuild too. Both builds fail. Do we know if upstream has some C++ dialect requirements that we're missing? /usr/bin/g++ -DBINPATH=\"/usr/bin\" -DBOOST_ALL_DYN_LINK -DENABLE_BINRELOC -DFREEORION_BUILD_PARSE -DFREEORION_LINUX -DNDEBUG -DSHAREPATH=\"/usr/share\" -I/builddir/build/BUILD/src-tarball/GG/Boost::boost -I/builddir/build/BUILD/src-tarball/GG -O2 -flto=auto -ffat-lto-objects -fexc eptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-t ables -fstack-clash-protection -fcf-protection -DNDEBUG -fPIC -fvisibility=hidden -Wall -O3 -std=c++14 -MD -MT CMakeFiles/freeorionparseobj.dir/parse/GameRulesParser.cpp.o -MF CMakeFiles/freeorionparseobj.dir/parse/GameRulesParser.cpp.o.d -o CMakeFiles/freeorionparseobj.dir/parse/G ameRulesParser.cpp.o -c /builddir/build/BUILD/src-tarball/parse/GameRulesParser.cpp make[2]: Leaving directory '/builddir/build/BUILD/src-tarball/x86_64-redhat-linux-gnu' In file included from /usr/include/c++/11/bits/move.h:57, from /usr/include/c++/11/bits/stl_pair.h:59, from /usr/include/c++/11/bits/stl_algobase.h:64, from /usr/include/c++/11/bits/char_traits.h:39, from /usr/include/c++/11/string:40, from /usr/include/boost/system/detail/error_category.hpp:16, from /usr/include/boost/system/detail/error_code.hpp:13, from /usr/include/boost/system/error_code.hpp:13, from /usr/include/boost/filesystem/path_traits.hpp:22, from /usr/include/boost/filesystem/path.hpp:26, from /builddir/build/BUILD/src-tarball/parse/Parse.h:10, from /builddir/build/BUILD/src-tarball/parse/GameRulesParser.cpp:1: /usr/include/c++/11/type_traits: In instantiation of 'struct std::is_destructible<GameRules>': /usr/include/c++/11/future:769:21: required from 'class std::future<GameRules>' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:31:20: required from 'union boost::optional_detail::aligned_storage<std::future<GameRules> >::dummy_u' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:34:7: required from 'class boost::optional_detail::aligned_storage<std::future<GameRules> >' /usr/include/boost/optional/optional.hpp:775:18: required from 'class boost::optional_detail::optional_base<std::future<GameRules> >' /usr/include/boost/optional/optional.hpp:850:7: required from 'class boost::optional<std::future<GameRules> >' /builddir/build/BUILD/src-tarball/parse/../util/Pending.h:38:41: required from 'struct Pending::Pending<GameRules>' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:31:20: required from 'union boost::optional_detail::aligned_storage<Pending::Pending<GameRules> >::dummy_u' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:34:7: required from 'class boost::optional_detail::aligned_storage<Pending::Pending<GameRules> >' /usr/include/boost/optional/optional.hpp:775:18: required from 'class boost::optional_detail::optional_base<Pending::Pending<GameRules> >' /usr/include/boost/optional/optional.hpp:850:7: required from 'class boost::optional<Pending::Pending<GameRules> >' /builddir/build/BUILD/src-tarball/parse/../util/GameRules.h:157:83: required from here /usr/include/c++/11/type_traits:849:52: error: static assertion failed: template argument must be a complete class or an unbounded array 849 | static_assert(std::__is_complete_or_unbounded(__type_identity<_Tp>{}), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/11/type_traits:849:52: note: 'std::__is_complete_or_unbounded<std::__type_identity<GameRules> >((std::__type_identity<GameRules>{}, std::__type_identity<GameRules>()))' evaluates to false In file included from /builddir/build/BUILD/src-tarball/parse/../util/Pending.h:10, from /builddir/build/BUILD/src-tarball/parse/../util/GameRules.h:5, from /builddir/build/BUILD/src-tarball/parse/GameRulesParser.cpp:6: /usr/include/c++/11/future: In instantiation of 'class std::future<GameRules>': /usr/include/boost/optional/detail/optional_aligned_storage.hpp:31:20: required from 'union boost::optional_detail::aligned_storage<std::future<GameRules> >::dummy_u' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:34:7: required from 'class boost::optional_detail::aligned_storage<std::future<GameRules> >' /usr/include/boost/optional/optional.hpp:775:18: required from 'class boost::optional_detail::optional_base<std::future<GameRules> >' /usr/include/boost/optional/optional.hpp:850:7: required from 'class boost::optional<std::future<GameRules> >' /builddir/build/BUILD/src-tarball/parse/../util/Pending.h:38:41: required from 'struct Pending::Pending<GameRules>' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:31:20: required from 'union boost::optional_detail::aligned_storage<Pending::Pending<GameRules> >::dummy_u' /usr/include/boost/optional/detail/optional_aligned_storage.hpp:34:7: required from 'class boost::optional_detail::aligned_storage<Pending::Pending<GameRules> >' /usr/include/boost/optional/optional.hpp:775:18: required from 'class boost::optional_detail::optional_base<Pending::Pending<GameRules> >' /usr/include/boost/optional/optional.hpp:850:7: required from 'class boost::optional<Pending::Pending<GameRules> >' /builddir/build/BUILD/src-tarball/parse/../util/GameRules.h:157:83: required from here /usr/include/c++/11/future:769:21: error: static assertion failed: result type must be destructible 769 | static_assert(is_destructible<_Res>{}, | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/11/future:769:21: note: 'std::is_destructible<GameRules>()' evaluates to false /usr/include/c++/11/future: In instantiation of 'class std::shared_future<GameRules>': /usr/include/c++/11/future:788:66: required from 'std::future<_Res>::future(std::future<_Res>&&) [with _Res = GameRules]' /usr/include/boost/optional/optional.hpp:409:8: required from 'void boost::optional_detail::optional_base<T>::construct(boost::optional_detail::optional_base<T>::rval_reference_type) [with T = std::future<GameRules>; boost::optional_detail::optional_base<T>::rval_reference_type = std::future<GameRules>&&]' /usr/include/boost/optional/optional.hpp:211:18: required from 'boost::optional_detail::optional_base<T>::optional_base(boost::optional_detail::optional_base<T>&&) [with T = std::future<GameRules>]' /usr/include/boost/optional/optional.hpp:975:5: required from 'Pending::Pending<T>::Pending(Pending::Pending<T>&&) [with T = GameRules]' /usr/include/boost/optional/optional.hpp:409:8: required from 'void boost::optional_detail::optional_base<T>::construct(boost::optional_detail::optional_base<T>::rval_reference_type) [with T = Pending::Pending<GameRules>; boost::optional_detail::optional_base<T>::rval_reference_type = Pending::Pending<GameRules>&&]' /usr/include/boost/optional/optional.hpp:211:18: required from 'boost::optional_detail::optional_base<T>::optional_base(boost::optional_detail::optional_base<T>&&) [with T = Pending::Pending<GameRules>]' /usr/include/boost/optional/optional.hpp:975:5: required from here /usr/include/c++/11/future:906:21: error: static assertion failed: result type must be destructible 906 | static_assert(is_destructible<_Res>{}, | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/11/future:906:21: note: 'std::is_destructible<GameRules>()' evaluates to false
Stale review, resetting ticket status
Version 0.5-rc2 is released. Would it be updated to attempt to resolve building issues?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.