Bug 1881201 - Generic Mailer method creates enable_starttls_auto key conditionally.
Summary: Generic Mailer method creates enable_starttls_auto key conditionally.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Appliance
Version: 5.11.7
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.9
Assignee: Daniel Berger
QA Contact: Mike Shriver
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-21 19:25 UTC by Tina Fitzgerald
Modified: 2023-12-15 19:27 UTC (History)
6 users (show)

Fixed In Version: 5.11.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-05 22:04:55 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:
simaishi: cfme-5.11.z+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 5387591 0 None None None 2020-10-28 09:37:29 UTC
Red Hat Product Errata RHBA-2020:4967 0 None None None 2020-11-05 22:05:01 UTC

Comment 2 Dave Johnson 2020-09-21 20:05:15 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 5 Daniel Berger 2020-09-29 13:14:27 UTC
https://github.com/ManageIQ/manageiq/pull/20609

Comment 6 CFME Bot 2020-09-30 17:45:26 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/96766e82037311d8ee5ec0b0b73325b6aaf8dc8b
commit 96766e82037311d8ee5ec0b0b73325b6aaf8dc8b
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Tue Sep 29 20:00:03 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Sep 30 17:40:37 2020 +0000

    Merge pull request #20609 from djberg96/generic_mailer_smtp

    Update optional smtp key handling in GenericMailer#set_mailer_smtp

    (cherry picked from commit c376bd235ae4e4dbd59992855a257bed4fd4bcab)

    https://bugzilla.redhat.com/show_bug.cgi?id=1881201

 app/mailers/generic_mailer.rb | 2 +-
 spec/mailers/generic_mailer_spec.rb | 8 +
 2 files changed, 9 insertions(+), 1 deletion(-)

Comment 7 Mike Shriver 2020-10-26 15:19:35 UTC
Tested on CFME 5.11.9.0.

When `Start TLS Automatically` setting is Yes or No in the SMTP server settings page, the value is included in the GenericMailer worker.

With UI set to 'Yes':
[----] I, [2020-10-26T10:19:26.705145 #6362:2b157612a62c]  INFO -- : MIQ(GenericMailer#set_mailer_smtp) Mailer settings: {:address=>"<redacted>", :port=>"40697", :domain=>"mydomain.com", :authentication=>nil, :user_name=>nil, :enable_starttls_auto=>true, :openssl_verify_mode=>"none"}



With UI set to 'No':
[----] I, [2020-10-26T11:04:27.340077 #6362:2b157612d6b0]  INFO -- : MIQ(GenericMailer#set_mailer_smtp) Mailer settings: {:address=>"<redacted>", :port=>"39199", :domain=>"mydomain.com", :authentication=>nil, :user_name=>nil, :enable_starttls_auto=>false, :openssl_verify_mode=>"none"}



In both cases, emails were successfully sent to an email relay without TLS enabled.

Comment 12 errata-xmlrpc 2020-11-05 22:04:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (CloudForms 5.0.9 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4967


Note You need to log in before you can comment on or make changes to this bug.