Bug 1882014 (CVE-2020-25682) - CVE-2020-25682 dnsmasq: buffer overflow in extract_name() due to missing length check when DNSSEC is enabled
Summary: CVE-2020-25682 dnsmasq: buffer overflow in extract_name() due to missing leng...
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2020-25682
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1896024 1896026 1896027 1896028 1917782 1917788
Blocks: 1875522
TreeView+ depends on / blocked
 
Reported: 2020-09-23 15:24 UTC by Riccardo Schirone
Modified: 2022-04-17 21:01 UTC (History)
19 users (show)

Fixed In Version: dnsmasq 2.83
Clone Of:
Environment:
Last Closed: 2021-01-19 17:59:11 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2021:0199 0 None None None 2021-01-20 18:19:04 UTC
Red Hat Product Errata RHSA-2021:0150 0 None None None 2021-01-19 13:16:40 UTC
Red Hat Product Errata RHSA-2021:0151 0 None None None 2021-01-19 13:34:14 UTC
Red Hat Product Errata RHSA-2021:0152 0 None None None 2021-01-19 13:11:42 UTC

Description Riccardo Schirone 2020-09-23 15:24:28 UTC
A buffer overflow vulnerability was discovered in the way dnsmasq extract names from DNS packets before validating them with DNSSEC data. An attacker, who can create valid DNS replies, could use this flaw to cause an overflow with arbitrary data in a heap-allocated memory, possibly executing code on the machine. The flaw is in rfc1035.c:extract_name() function, which writes data to the memory pointed by `name` assuming MAXDNAME*2 bytes are available in the buffer. However, in some code execution paths it is possible extract_name() gets passed an offset from the base buffer, thus reducing in practice the number of available bytes that can be written in the buffer.

Comment 6 Riccardo Schirone 2020-11-04 13:50:03 UTC
To trigger the flaw, dnsmasq has to be compiled with HAVE_DNSSEC flag and DNSSEC has to be enabled (e.g. with --dnssec option). Moreover, the attacker shall either control a DNS server used in the domain name resolution process or be able to inject packets on the network in such a way to trick dnsmasq into accepting them (e.g. guessing the ID, random port used, etc.). To be involved in the domain name resolution process, an attacker could trick a victim which uses dnsmasq into accessing some resources on a controlled domain, e.g. trick the user to visit a website or open an email. If the dnsmasq service is an Open Resolver (it accepts requests from the whole Internet) or the attacker is on the internal network covered by dnsmasq, the attack can be performed at will by the attacker, without requiring any other user interaction.

Comment 18 Riccardo Schirone 2021-01-19 11:30:12 UTC
Acknowledgments:

Name: Moshe Kol (JSOF), Shlomi Oberman (JSOF)

Comment 19 Riccardo Schirone 2021-01-19 11:30:15 UTC
Statement:

This issue does not affect the versions of dnsmasq as shipped with Red Hat Enterprise Linux 5, 6, and 7 as they are not compiled with DNSSEC support.

Comment 20 Riccardo Schirone 2021-01-19 11:30:19 UTC
External References:

https://www.jsof-tech.com/disclosures/dnspooq/

Comment 21 Riccardo Schirone 2021-01-19 11:30:22 UTC
Mitigation:

The only known way to mitigate this flaw is to disable DNSSEC altogether, by removing the `--dnssec` command line option or the `dnssec` option from dnsmasq configuration file.

Comment 22 Riccardo Schirone 2021-01-19 11:56:26 UTC
Created dnsmasq tracking bugs for this issue:

Affects: fedora-all [bug 1917782]

Comment 24 errata-xmlrpc 2021-01-19 13:11:39 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8.1 Extended Update Support

Via RHSA-2021:0152 https://access.redhat.com/errata/RHSA-2021:0152

Comment 25 errata-xmlrpc 2021-01-19 13:16:37 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2021:0150 https://access.redhat.com/errata/RHSA-2021:0150

Comment 27 errata-xmlrpc 2021-01-19 13:34:10 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8.2 Extended Update Support

Via RHSA-2021:0151 https://access.redhat.com/errata/RHSA-2021:0151

Comment 28 Product Security DevOps Team 2021-01-19 17:59:11 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-25682


Note You need to log in before you can comment on or make changes to this bug.