Description of problem: When writing HTML code, entering <h1, <h2, <h3, <h4, <h5 or <h6 with the next line empty results in a gtksourceview hang and gedit disabling HTML highlighting for this reason. The same hang happens when entering <titl for the <title> tag, but this one doesn't require the next line to be empty, it is enough that any later line before the closing </html> tag is empty. This is a regression from the fix for https://gitlab.gnome.org/GNOME/gtksourceview/-/issues/108 gtksourceview4-4.6.1-1.fc32.x86_64 gedit-3.36.2-1.fc32.x86_64 How reproducible: Always Steps to Reproduce: 1. Open gedit, start a new document 2. Select HTML as highlighting mode 3. Enter the following content: <html> <head> </head> <body> </body> </html> 4. Start typing <title> at the next line after <head> 5. Close gedit, repeat steps 1 to 3. 6. Insert one or more additional line breaks after <body> 7. Start typing either of <h1>, <h2>, <h3>, <h4>, <h5> or <h6> after <body> with the following line remaining empty Actual results: After step 4 or step 7, gedit disables highlighting, printing (gedit:4273): GtkSourceView-CRITICAL **: <timestamp skipped>: Highlighting a single line took too much time, syntax highlighting will be disabled to stderr. Expected results: Syntax highlighting remains active without perceptible lag in text input. Additional info: diff --git a/data/language-specs/html.lang b/data/language-specs/html.lang index effd373b..7b31a8ec 100644 --- a/data/language-specs/html.lang +++ b/data/language-specs/html.lang @@ -113,7 +113,6 @@ <include> <context sub-pattern="0" where="start" style-ref="tag"/> <context sub-pattern="0" where="end" style-ref="tag"/> - <context ref="embedded-lang-hook"/> <context ref="embedded-lang-hook-content"/> </include> </context> @@ -132,7 +131,6 @@ <context end-parent="true"> <match>(?=\%{h1-close})</match> </context> - <context ref="embedded-lang-hook"/> <context ref="embedded-lang-hook-content"/> <context ref="tag"/> </include> @@ -180,7 +178,6 @@ <context end-parent="true"> <match>(?=\%{h3-close})</match> </context> - <context ref="embedded-lang-hook"/> <context ref="embedded-lang-hook-content"/> <context ref="tag"/> </include> @@ -204,7 +201,6 @@ <context end-parent="true"> <match>(?=\%{h4-close})</match> </context> - <context ref="embedded-lang-hook"/> <context ref="embedded-lang-hook-content"/> <context ref="tag"/> </include> @@ -228,7 +224,6 @@ <context end-parent="true"> <match>(?=\%{h5-close})</match> </context> - <context ref="embedded-lang-hook"/> <context ref="embedded-lang-hook-content"/> <context ref="tag"/> </include> avoids the issue, but I really don't understand what I am doing with this change yet.
Fedora version updated. This bugreport has been created in hope that someone with access to gitlab.gnome.org, now closed to "new" (old bugzilla.gnome.org bug reporters') registrations, might find it worth the hassle to file the issue upstream.
This message is a reminder that Fedora 33 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '33'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 33 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.