Bug 1882500 - CSR approver needs proper error logging
Summary: CSR approver needs proper error logging
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Michael Gugino
QA Contact: Milind Yadav
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-24 18:26 UTC by Michael Gugino
Modified: 2021-02-08 14:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-08 14:41:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Michael Gugino 2020-09-24 18:26:43 UTC
When the CSR approver discovers a CSR that it cannot/will not approve, we need to log with proper error level.  Right now we're logging with info level and it's confusing.

We're also logging innocuous stuff with warning level that should be info level, probably don't need to log at all.  Generally need to clean up logging.

Comment 2 Joel Speed 2020-09-30 11:12:56 UTC
@MGugino are you happy to look at this during the next sprint? I would expect a review of the logging for this component shouldn't take too long?

Comment 3 Michael Gugino 2020-10-26 19:57:59 UTC
This is blocked my refactor and unit test work.  Logging library we want is part of controller runtime package, which we're not using ATM.  Once that lands, can update the logging.

Comment 4 Joel Speed 2020-11-13 14:15:21 UTC
Still waiting on the refactor to land

Comment 5 Michael McCune 2020-12-04 20:26:10 UTC
the team is still working to merge the controller-runtime refactor

Comment 6 Joel Speed 2021-01-06 10:42:55 UTC
I'd argue this is more of a feature than a bug, perhaps we should convert this to a Jira task rather than tracking in bugzilla?

Either way, we aren't likely to be able to fix this in the 4.7 release so unsetting the target release

Comment 7 Joel Speed 2021-02-08 14:41:51 UTC
I've created https://issues.redhat.com/browse/OCPCLOUD-1105 to track this work instead.
We will groom this during backlog grooming and evaluate the importance of this then.


Note You need to log in before you can comment on or make changes to this bug.