Bug 1882529 - TriggerTemplate Annotations Issue
Summary: TriggerTemplate Annotations Issue
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.6.0
Assignee: Andrew Ballantyne
QA Contact: Gajanan More
URL:
Whiteboard:
Depends On:
Blocks: 1883342
TreeView+ depends on / blocked
 
Reported: 2020-09-24 20:22 UTC by Andrew Ballantyne
Modified: 2020-10-27 16:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:45:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
resources.yaml (1.76 KB, text/plain)
2020-09-24 20:22 UTC, Andrew Ballantyne
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 6744 0 None closed Bug 1882529: Removes the kubectl annotation from the created PLRs 2020-10-22 13:41:34 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:45:45 UTC

Description Andrew Ballantyne 2020-09-24 20:22:56 UTC
Created attachment 1716442 [details]
resources.yaml

h3. Description of problem:

When we create PipelineRuns we merge a bunch of things together to create a new PipelineRun. This PipelineRun typically has no problems when starting it via the Start Pipeline modal... however when it's used in the creation of a TriggerTemplate's resource (Add Trigger modal) it seems to get validated - if it contains an old issue with the definition it can prevent the trigger from being added.

h3. Prerequisites (if any, like setup, operators/versions):

OpenShift Pipelines 1.1.1

h3. Steps to Reproduce
# `oc apply -f resources.yaml` (attached file)
# Add Trigger on the Pipeline created
#* Select the TriggerBinding that is in the resources or the ClusterTriggerBinding `github-push`
#* The params don't matter so much for this issue

Note: If you remove the annotation `kubectl.kubernetes.io/last-applied-configuration` or set it to '' it no longer causes the issue.

h3. Actual results:

An error trying to create related to a field not in the TriggerTemplate:
 !Screen Shot 2020-09-24 at 2.18.14 PM.png|thumbnail! 

But it is in the TriggerTemplate.spec.resourcestemplates[0].metadata.annotations.

The annotation `kubectl.kubernetes.io/last-applied-configuration` seems to be read in when the TriggerTemplate is created.

h3. Expected results:

For the Trigger to be successfully added.

h3. Reproducibility (Always/Intermittent/Only Once):

Always

h3. Build Details:

4.6.0-0.nightly-2020-09-24-095222

Comment 2 Christoph Jerolimov 2020-10-02 13:27:35 UTC
Could verify this on cluster with version 4.6.0-0.nightly-2020-10-02-043144

Comment 5 errata-xmlrpc 2020-10-27 16:45:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.