Bug 1882542

+++ This bug was initially created as a clone of Bug #1785873 +++

Description of problem:

supervdsm runs lldptool against Infiniband interfaces and fails. It shall not even try. LLDP is used in IEEE 802 LANs that Infiniband is not part of. 
 
Version-Release number of selected component (if applicable):

    vdsm-network-4.40.0-1432.gitc29c23741.el8.x86_64

How reproducible:

    Run vdsm on a host with Infiniband interfaces.

Actual results:

    Tracebacks in supervdsm.log and GetlldpFailed events in the engine.

Expected results:

    Silence about LLDP in the case of Infiniband interfaces

Additional info:

The command that is run by supervdsm

# /usr/sbin/lldptool get-tlv -n -i ib0
Agent instance for device not found 

The traceback in supervdsm.log

MainProcess|jsonrpc/0::ERROR::2019-12-21 14:03:21,393::supervdsm_server::97::SuperVdsm.ServerCallback::(wrapper) Error in get_lldp_info
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/vdsm/supervdsm_server.py", line 95, in wrapper
    res = func(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/network/api.py", line 356, in get_lldp_info
    return lldp_info.get_info(filter)
  File "/usr/lib/python3.6/site-packages/vdsm/network/lldp/info.py", line 33, in get_info
    return {device: _get_info(device) for device in filter['devices']}
  File "/usr/lib/python3.6/site-packages/vdsm/network/lldp/info.py", line 33, in <dictcomp>
    return {device: _get_info(device) for device in filter['devices']}
  File "/usr/lib/python3.6/site-packages/vdsm/network/lldp/info.py", line 40, in _get_info
    dev_info['tlvs'] = Lldp.get_tlvs(device)
  File "/usr/lib/python3.6/site-packages/vdsm/network/lldp/lldpad.py", line 43, in get_tlvs
    return lldptool.get_tlvs(iface)
  File "/usr/lib/python3.6/site-packages/vdsm/network/lldpad/lldptool.py", line 93, in get_tlvs
    raise TlvReportLldpError(rc, stdout, err, iface)
vdsm.network.lldp.TlvReportLldpError: (1, 'Agent instance for device not found \n', '', 'ib0')

--- Additional comment from Dominik Holler on 2020-01-06 10:50:55 UTC ---

Thank you very much for reporting the Infiniband bugs!

Is there another problem, except the error in the logfile?

--- Additional comment from Alexander Murashkin on 2020-01-09 00:46:09 UTC ---

Also messages in the event log

VDSM harrier command GetLldpVDS failed: Internal JSON-RPC error: {'reason': "(1, 'Agent instance for device not found \\n', '', 'ib0')"}

In our case, the host has also Ethernet interfaces and LLDP is enabled on the host and on the switch. LLDP information, including switch port, can be displayed via CLI. But it is not displayed in oVirt web interface.

Maybe I am looking in a wrong place. Where exactly LLDP information is supposed to be displayed?

--- Additional comment from Dominik Holler on 2020-01-09 06:42:20 UTC ---

(In reply to Alexander Murashkin from comment #2)
> Also messages in the event log
> 
> VDSM harrier command GetLldpVDS failed: Internal JSON-RPC error: {'reason':
> "(1, 'Agent instance for device not found \\n', '', 'ib0')"}
> 
> In our case, the host has also Ethernet interfaces and LLDP is enabled on
> the host and on the switch. LLDP information, including switch port, can be
> displayed via CLI. But it is not displayed in oVirt web interface.
> 
> Maybe I am looking in a wrong place. Where exactly LLDP information is
> supposed to be displayed?

Is the lldp information of the Ethernet ports shown in UI like in the example in
https://www.ovirt.org/develop/release-management/features/network/lldp.html#graphical-user-interface
?

--- Additional comment from Alexander Murashkin on 2020-01-10 01:47:45 UTC ---

Link layer information is not shown at all. See the attached screenshot.