Bug 1882653 - The Approval should display the Manual after the APPROVAL changed to Manual from the Automatic
Summary: The Approval should display the Manual after the APPROVAL changed to Manual f...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: 4.7.0
Assignee: Robb Hamilton
QA Contact: Jian Zhang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-25 09:38 UTC by Jian Zhang
Modified: 2021-02-24 15:22 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Subscriptions with an automatic approval strategy behave as if they have a manual approval strategy if another subscription in the same namespace has a manual approval strategy. Consequence: It's not apparent in the UI that automatic approval strategy subscriptions are not automatically approved when another subscription in the same namespace has a manual approval strategy. Fix: The UI should notify the user there is another Subscription in the namespace with a manual approval strategy, and the presence of that manual Subscription results in Subscriptions with an automatic approval strategy to behave as manual. Result: The UI notifies the user that a Subscription with a manual approval strategy causes all Subscriptions in the namespace to behave as manual.
Clone Of:
Environment:
Last Closed: 2021-02-24 15:21:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 7054 0 None closed Bug 1882653: Convey automatic subscriptions in same namespace as a m… 2021-02-17 20:57:06 UTC
Red Hat Knowledge Base (Solution) 5493011 0 None None None 2020-10-15 17:21:22 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:22:07 UTC

Description Jian Zhang 2020-09-25 09:38:31 UTC
Description of problem:
The Approval still display the Atomatic, but, displays 1 requires approval. Seem the screenshot https://user-images.githubusercontent.com/15416633/94247439-b1e07d00-ff4f-11ea-98ed-67b80472e635.png


Version-Release number of selected component (if applicable):
Cluster version is 4.6.0-0.nightly-2020-09-25-034954
mac:~ jianzhang$ oc -n openshift-operator-lifecycle-manager exec catalog-operator-568996d5bd-zflr9 -- olm --version
OLM version: 0.16.1
git commit: be18debfbb25ba768921373d48aa761b951eca59

How reproducible:
always

Steps to Reproduce:
1. Install OCP 4.6

2. Installed the 3scale-community-operator, akka-cluster-operator-certified with manual mode and don't approve them, And then, install the Etcd operator with Automatic mode.

mac:~ jianzhang$ oc get sub -n default
NAME                              PACKAGE                           SOURCE                CHANNEL
3scale-community-operator         3scale-community-operator         community-operators   threescale-2.8
akka-cluster-operator-certified   akka-cluster-operator-certified   certified-operators   beta
etcd                              etcd                              community-operators   singlenamespace-alpha
mac:~ jianzhang$ oc get ip -n default
NAME            CSV                                      APPROVAL   APPROVED
install-cmbtw   akka-cluster-operator-certified.v1.0.0   Manual     false
install-gtm6n   3scale-community-operator.v0.5.1         Manual     false
install-gxkvp   3scale-community-operator.v0.5.1         Manual     false


mac:~ jianzhang$ oc get ip install-cmbtw -o=jsonpath='{.spec.clusterServiceVersionNames}'
["akka-cluster-operator-certified.v1.0.0","etcdoperator.v0.9.4","3scale-community-operator.v0.5.1"]

mac:~ jianzhang$ oc get ip install-gtm6n -o=jsonpath='{.spec.clusterServiceVersionNames}'
["3scale-community-operator.v0.5.1","akka-cluster-operator-certified.v1.0.0"]

mac:~ jianzhang$ oc get ip install-gxkvp -o=jsonpath='{.spec.clusterServiceVersionNames}'
["3scale-community-operator.v0.5.1"]


3. Check the etcd operator status.

Actual results:
The etcd operator's automatic approval mode was changed to Manual as expected. But, the Approval still display the Atomatic, but, displays 1 requires approval. Seem the screenshot https://user-images.githubusercontent.com/15416633/94247439-b1e07d00-ff4f-11ea-98ed-67b80472e635.png

Expected results:
Should display Manual mode on the WebConsole. Or, don't change the Automatic mode to Manual mode automatically.

Additional info:

Comment 2 Robb Hamilton 2020-10-02 12:53:33 UTC
Will investigate next sprint.

Comment 3 Robb Hamilton 2020-10-05 18:14:29 UTC
This is a known limitation of OLM, but the console can do a better job of notifying the user what is happening.  Going to engage UXD for design input.

Comment 4 Robb Hamilton 2020-10-05 18:20:27 UTC
There is an existing design story for this.  Per Peter Kreuser:

"Yeah this is an unfortunate limitation with OLM that I thought was on the radar to fix. I had opened a design story to do some short term fix earlier this year but I think the thought was that it wasn't worth the effort to do the short term fix if the actual underlying issue was actually getting resolved in olm: https://issues.redhat.com/browse/PD-395"

So if this is going to get fixed in OLM, there is no need for a short-term fix notifying the user.  Will let PM decide what to do here.

Comment 5 Robb Hamilton 2020-10-19 15:12:59 UTC
Waiting on design from Peter Kreuser before implementing fix.

Comment 9 Jian Zhang 2020-11-10 06:30:52 UTC
Cluster version is 4.7.0-0.nightly-2020-11-09-235738
[root@preserve-olm-env data]# oc adm release info registry.svc.ci.openshift.org/ocp/release:4.7.0-0.nightly-2020-11-09-235738 --commits |grep console
  console                                        https://github.com/openshift/console                                        6e20c70ff4affc5ab307aef0bf80bf063e99f48a
  console-operator                               https://github.com/openshift/console-operator                               54699a7c42f275f6591fabcdf5e418dba8eebe91

1, Installed the 3scale-community-operator, akka-cluster-operator-certified with manual mode and don't approve them, And then, install the Etcd operator with Automatic mode.

[root@preserve-olm-env data]# oc get sub -n default
NAME                              PACKAGE                           SOURCE                CHANNEL
3scale-community-operator         3scale-community-operator         community-operators   threescale-2.9
akka-cluster-operator-certified   akka-cluster-operator-certified   certified-operators   beta
etcd                              etcd                              community-operators   singlenamespace-alpha

[root@preserve-olm-env data]# oc get ip -n default
NAME            CSV                                      APPROVAL   APPROVED
install-5slcs   akka-cluster-operator-certified.v1.0.0   Manual     false
install-8sff8   3scale-community-operator.v0.6.0         Manual     false
install-tsh6j   etcdoperator.v0.9.4                      Manual     false
[root@preserve-olm-env data]# oc get ip install-5slcs -n default -o=jsonpath='{.spec.clusterServiceVersionNames}'
["akka-cluster-operator-certified.v1.0.0","3scale-community-operator.v0.6.0"]
[root@preserve-olm-env data]# 
[root@preserve-olm-env data]# oc get ip install-8sff8  -n default -o=jsonpath='{.spec.clusterServiceVersionNames}'
["3scale-community-operator.v0.6.0"]
[root@preserve-olm-env data]# 
[root@preserve-olm-env data]# oc get ip install-tsh6j  -n default -o=jsonpath='{.spec.clusterServiceVersionNames}'
["etcdoperator.v0.9.4","3scale-community-operator.v0.6.0","akka-cluster-operator-certified.v1.0.0"]

I can get the approval tips on the web console:
https://user-images.githubusercontent.com/15416633/98635380-d5c11c00-235f-11eb-86d0-28c9c002ceb9.png
https://user-images.githubusercontent.com/15416633/98635542-2cc6f100-2360-11eb-8641-e34dc330ea4e.png

LGTM, verify it.

Comment 12 errata-xmlrpc 2021-02-24 15:21:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.