Bug 1882735 - Some <title>s contain unexpected comma
Summary: Some <title>s contain unexpected comma
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.6.0
Assignee: Robb Hamilton
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-25 13:30 UTC by Robb Hamilton
Modified: 2020-10-27 16:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Version: 4.6.0-0.nightly-2020-09-25-085318 Cluster ID: 8f9611a1-a08e-494c-bb30-bc5365ca36c4 Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36
Last Closed: 2020-10-27 16:45:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 6757 0 None open Bug 1882735: Remove unexpected comma from <title> 2020-09-28 12:57:53 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:45:45 UTC

Description Robb Hamilton 2020-09-25 13:30:48 UTC
Description of problem:  A bug a react-helmet results in an unexpected comma being output to page <title>s when there is an expression in the <title>.  See https://github.com/nfl/react-helmet/issues/408.  See https://github.com/nfl/react-helmet/issues/408#issuecomment-499763409 for workaround.


Steps to Reproduce:
1.  Visit /monitoring/alertmanagerconfig/receivers/~new
2.  Note the <title> is `Create, Receiver`
3.  The comma is not desired or expected.

Actual results:  An unexpected comma is present in the title.


Expected results:  No comma should be included in the title.


Additional info:  There may be other instances of this bug.

Comment 1 Robb Hamilton 2020-09-25 13:42:38 UTC
A quick search of the code base shows no other instances of the bug.

Comment 3 Yadan Pei 2020-09-29 06:48:29 UTC
goes to /monitoring/alertmanagerconfig/receivers/~new page, the title is `Create Receiver · Red Hat OpenShift Container Platform`, no comma 

Moving to VERIFIED on 4.6.0-0.nightly-2020-09-28-171716

Comment 4 Yadan Pei 2020-09-29 07:06:19 UTC
Also grep among the code base 
$ grep  -nr '<Helmet>' -A1 frontend/public/

Checked some other pages when there is an expression in <title> element, such as <title>{`${name || SilenceResource.label} · Details`}</title>
 <title>{`${name} · ${heading}`}</title>

Comment 5 Robb Hamilton 2020-09-29 12:10:40 UTC
Thanks, Yadan.  Those other instances are okay because they are within template literals (``), which is the workaround.

Comment 6 Yadan Pei 2020-09-30 01:45:38 UTC
Got it : )

Comment 9 errata-xmlrpc 2020-10-27 16:45:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.