Bug 1882970 - Review Request: R-presser - Lightweight Web Server for Testing
Summary: Review Request: R-presser - Lightweight Web Server for Testing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1882978
TreeView+ depends on / blocked
 
Reported: 2020-09-27 04:52 UTC by Elliott Sales de Andrade
Modified: 2020-10-09 15:00 UTC (History)
2 users (show)

Fixed In Version: R-presser-1.1.0-1.fc34
Clone Of:
Environment:
Last Closed: 2020-10-05 00:16:56 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2020-09-27 04:52:32 UTC
Spec URL: https://qulogic.fedorapeople.org/reviews/R-presser/R-presser.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-presser/R-presser-1.1.0-1.fc32.src.rpm

Description:
Create a web app that makes it easier to test web clients without using the
internet. It includes a web app framework with path matching and parameters
and templates. Can parse various 'HTTP' request bodies. Can send 'JSON'
data or files from the disk. Includes a web app that implements the
<https://httpbin.org> web service.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=52339056

Comment 1 José Matos 2020-09-29 11:20:39 UTC
The license is correct and appropriated for Fedora. The spec file follows the
Fedora package guidelines.

In this cases these are the fedora-review complaints:

Issues:
=======
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

The first is a bug as DESCRIPTION is not marked as %doc and the others are as
intended.

Another micro-issue is that probably examples and credits (in %files) could be marked as %doc.
(One could even argue that %doc is becoming obsolete but that is another issue.) :-)

So the package is approved. 

Comment 2 Gwyn Ciesla 2020-09-30 13:03:30 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-presser

Comment 3 Fedora Update System 2020-09-30 23:14:47 UTC
FEDORA-2020-7d3e8189f1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

Comment 4 Fedora Update System 2020-09-30 23:14:56 UTC
FEDORA-2020-e15eb4fc79 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

Comment 5 Fedora Update System 2020-09-30 23:15:05 UTC
FEDORA-2020-6e5f3336b7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

Comment 6 Fedora Update System 2020-10-01 01:20:55 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d3e8189f1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-10-01 01:30:05 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6e5f3336b7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-10-01 02:15:49 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-e15eb4fc79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-10-05 00:16:56 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-10-09 15:00:58 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-10-09 15:00:59 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.