Bug 1883847 - The UI does not show checkbox for enable encryption at rest for OCS
Summary: The UI does not show checkbox for enable encryption at rest for OCS
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Storage Plugin
Version: 4.6
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 4.7.0
Assignee: Bipul Adhikari
QA Contact: Neha Berry
URL:
Whiteboard:
Depends On:
Blocks: 1886651
TreeView+ depends on / blocked
 
Reported: 2020-09-30 11:58 UTC by Petr Balogh
Modified: 2021-02-24 15:22 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1886651 (view as bug list)
Environment:
Last Closed: 2021-02-24 15:21:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Encryption CheckBox (81.51 KB, image/png)
2020-10-07 09:44 UTC, Oded
no flags Details
deploy_olm (758 bytes, text/plain)
2020-10-07 09:51 UTC, Oded
no flags Details
UI screenshot with no encryption box (123.18 KB, image/png)
2020-10-07 13:37 UTC, Neha Berry
no flags Details
Screenshot from UI for OCP 4.7 (112.89 KB, image/png)
2020-10-09 10:44 UTC, Neha Berry
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 6794 0 None closed Bug 1883847: Fix typo for feature guard flag spelling 2020-11-01 21:56:23 UTC
Github openshift console pull 6860 0 None closed Bug 1883847: Fix subscription name issue for OCS 2020-11-01 21:56:23 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:22:21 UTC

Description Petr Balogh 2020-09-30 11:58:14 UTC
Description of problem:
The UI does not show the checkbox for encryption at rest when creating storageCluster.

Talked to Bipul Adhikari about this and he found the issue, so reporting this BZ and some more info from Bipul:

Scenario: UI uses OCS-operator CSV to guard features from showing with any ocs-operator. Simiarly encryption is also feature guarded and the annotation required for it is present only in OCS Operator 4.6 latest build.
The problem: UI has used the wrong spelling for encryption (as pointed above) hence the UI is not finding that string in the annotation and not showing up. 
The fix: Correct the spelling in UI feature detection logic.

Version-Release number of selected component (if applicable):
OCS: quay.io/rhceph-dev/ocs-registry:4.6.0-102.ci
OCP: 4.6.0-0.nightly-2020-09-30-052433

How reproducible:


Steps to Reproduce:
1. Install OCS operator
2. Try to create storage cluster


Actual results:
No checkbox for encryption


Expected results:
Have checkbox fore enable/disable encryption at rest


Additional info:
Must gather:
http://magna002.ceph.redhat.com/ocsci-jenkins/openshift-clusters/jnk-pr2696-b2965/jnk-pr2696-b2965_20200930T085558/logs/deployment_1601456388/ocs_must_gather/quay-io-rhceph-dev-ocs-must-gather-sha256-0b1c4b047c5973c326295d9dea88ce6b8115d789c67967efd6be042f16ebe920/

Comment 2 Petr Balogh 2020-10-02 09:59:19 UTC
Verified on build:
4.6.0-0.nightly-2020-10-02-043144

Now I see checkbox ;)

Comment 4 Oded 2020-10-07 09:42:39 UTC
Bug Reconstructed on 4.6.0-0.nightly-2020-10-05-234751

SetUp:
Provider:VSphere
OpenShift Version:4.6.0-0.nightly-2020-10-05-234751
Update Channel:stable-4.6


Test Process:
1.Deploy_olm (On OCP4.6, OCS Operator wont be shown in the operator hub without this command)
$ oc create -f deploy_olm.yaml

2.UI:Operators -> OperatorHub -> OpenShift Container Storage

3.Install OCS Operator 
OCS Operator 4.6.0-104.ci Installed (success)

4.UI: Operators → Installed Operators -> Storage Cluster Tab-> Create OCS Cluster Service

5.UI does not show checkbox for enable encryption
*attached screenshot

Comment 5 Oded 2020-10-07 09:44:07 UTC
Created attachment 1719670 [details]
Encryption CheckBox

Comment 6 Oded 2020-10-07 09:51:02 UTC
Created attachment 1719674 [details]
deploy_olm

Comment 7 Neha Berry 2020-10-07 12:50:00 UTC
Please note

Apart from UI fix, there was supposed to be a fix from operator side too - https://github.com/openshift/ocs-operator/pull/754 which was made

https://bugzilla.redhat.com/show_bug.cgi?id=1883253

Fixed In Version: 4.6.0-106.ci

Hence, @oded we may have to test with a newer OCS build

Comment 8 Petr Balogh 2020-10-07 13:24:14 UTC
Oded I see your cluster is 4.6.0-104.ci build.

IIRC I've tested on build 4.6.0-107.ci which should have already a fix as Neha pointed out it's fixed from build number 106.

Can you upgrade your cluster to new build and check again?

Comment 9 Neha Berry 2020-10-07 13:37:32 UTC
Created attachment 1719752 [details]
UI screenshot with no encryption box

The encryption box has actually disappeared from latest OCP builds even though both the UI bug and the ocs-operator bug were ON_QA

$ oc get csv -n openshift-storage
NAME                         DISPLAY                       VERSION        REPLACES   PHASE
ocs-operator.v4.6.0-585.ci   OpenShift Container Storage   4.6.0-585.ci              Succeeded

OR 
OCS = ocs-operator.v4.6.0-113.ci (same as above)

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.6.0-0.nightly-2020-10-07-022140   True        False         98m     Cluster version is 4.6.0-0.nightly-2020-10-07-022140


__________________________________________________________


Additional Info
=====================
OCS operator BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1883253
UI BZ  - https://bugzilla.redhat.com/show_bug.cgi?id=1883847

Both are ON_QA and till yesterday I saw the Disabled Encryption box in Create Storagecluster page

IIRC, with following builds, the box was present

OCP: 4.6.0-0.nightly-2020-10-05-234751
OCS:  ocs-operator.v4.6.0-113.ci

Comment 10 Neha Berry 2020-10-07 13:40:05 UTC
Chat thread - https://chat.google.com/room/AAAA76Pbvwc/lcI7o8n9vow

Comment 14 Neha Berry 2020-10-09 10:44:49 UTC
Created attachment 1720199 [details]
Screenshot from UI for OCP 4.7

verified on OCP 4.7 CI builds.

The encryption box is now added back, as verified in OCP 4.7 + OCS 4.6 build

OCP = 4.7.0-0.ci-2020-10-09-055453
OCS = ocs-operator.v4.6.0-593.ci

Moving the BZ to verified so that the fix can be backported to 4.6 as well.

Thanks

Comment 18 errata-xmlrpc 2021-02-24 15:21:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.