Description of problem: The fix for BZ 1879993 forces the v2v-vmware config map to have only 3 entries. It replaces the whole data, instead of merging to override some specific entries. This is a regression as it breaks the existing VMware import feature. The VDDK image is specified in the v2v-vmware config map, see https://docs.openshift.com/container-platform/4.5/virt/virtual_machines/importing_vms/virt-importing-vmware-vm.html#virt-creating-vddk-image_virt-importing-vmware-vm. Version-Release number of selected component (if applicable): 2.5.0 How reproducible: Always Steps to Reproduce: 1. Create a vddk-init-image entry in the openshift-cnv/v2v-vmware config map Actual results: The entry is deleted Expected results: The entry is present Additional info:
Created attachment 1718469 [details] Warning message
The fix is basically just an hack to have HCO ignoring the additional values injected by the user into that config map. But this is still a bad design and indeed the UI is going to emit a warning (please see the attached screenshot), on the other side we are not going to properly fix it before 2.6.0. Pan, can we please add a note to https://docs.openshift.com/container-platform/4.5/virt/virtual_machines/importing_vms/virt-importing-vmware-vm.html#virt-creating-vddk-image_virt-importing-vmware-vm saying that the user can simply ignore that warning message on 2.5?
targeting this bug for 2.5 (as you already fixed the major problem) but I think we should duplicate/track this for 2.6 as well.
How to verify: Trying to edit v2v-vmware config map in openshift-cnv namespace, the user should be able to successfully add/edit vddk-init-image value while only v2v-conversion-image and kubevirt-vmware-image should be really managed by the operator.
Simone, I'm happy to update the docs. However, looking at the link you provided, the user is instructed to edit the ConfigMap by using `oc edit configmap`. Does a similar warning happen via the CLI? If not, perhaps we can just put this in the release notes as a known issue in the event that a user tries to edit the config map via the web console. Or if there is a similar warning via the CLI, perhaps we need both :) Let me know what you think. Thanks!
Verified in 2.5 Verified that it's possible to edit/add vddk-init-iamge value in the v2v-vmware config map in the openshift-cnv namespace.
(In reply to Pan Ousley from comment #5) > Simone, I'm happy to update the docs. However, looking at the link you > provided, the user is instructed to edit the ConfigMap by using `oc edit > configmap`. Does a similar warning happen via the CLI? No, the warning is visible only in the UI. > If not, perhaps we can just put this in the release notes as a known > issue in the event that a user tries to edit the config map via the > web console. Yes, it makes sense. +1
@Simone, please review the following PR for this Known Issue: https://github.com/openshift/openshift-docs/pull/27239 Thanks!
Doc update: Simone and Nandini both approved my PR, so I have merged the known issue into the OpenShift Virtualization 2.5 release notes.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Virtualization 2.5.0 Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:5127