Bug 1884702 - Update the login.defs manual page to remove references to LOGIN_STRING
Summary: Update the login.defs manual page to remove references to LOGIN_STRING
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: shadow-utils
Version: 8.0
Hardware: All
OS: Linux
Target Milestone: rc
: 8.5
Assignee: Iker Pedrosa
QA Contact: Anuj Borah
Whiteboard: sync-to-jira review
Depends On:
TreeView+ depends on / blocked
Reported: 2020-10-02 17:45 UTC by Paulo Andrade
Modified: 2021-11-10 08:24 UTC (History)
6 users (show)

Fixed In Version: shadow-utils-4.6-13.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-11-09 19:42:14 UTC
Type: Bug
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1804766 0 low CLOSED login.defs man page has incorrect information for login(1) 2023-03-07 11:49:09 UTC
Red Hat Product Errata RHBA-2021:4417 0 None None None 2021-11-09 19:42:20 UTC

Description Paulo Andrade 2020-10-02 17:45:44 UTC
/etc/login.defs documents the LOGIN_STRING option.
This option could be customized like:

LOGIN_STRING           "%s's Password: " 

to show the username and the Password prompt, as documented.

There are a few different layers calling 'pam_get_authtok', most,
if not all, pass NULL as prompt value. Instead of using a hardcoded
default of 'Password: ', it should parse LOGIN_STRING from
/etc/login.defs. Another option, and also for consistency, maybe
there should also exist a PAM_PASSWORD_PROMPT pair to PAM_USER_PROMPT.
In that case, it could be set by the login program.

Comment 2 Iker Pedrosa 2020-10-05 07:15:42 UTC
I don't think this issue is critical enough to include it in RHEL7. Do you mind if I change it to RHEL8?

By the way, I'm changing the component to shadow-utils, since this is the one handling LOGIN_STRING.

Comment 3 Paulo Andrade 2020-10-05 12:31:38 UTC
Just a note, shadow-utils documents it, but in the current state (easiest fix) it is pam
that should parse and LOGIN_STRING from /etc/login.defs.

Comment 4 Iker Pedrosa 2020-10-06 15:21:59 UTC
I agree that it should be pam. Moreover, I'm changing product to RHEL8.

Comment 9 Iker Pedrosa 2021-04-27 08:37:10 UTC
After a discussion with upstream (https://github.com/linux-pam/linux-pam/pull/356) I think that it doesn't make much sense to include the LOGIN_STRING functionality in pam. So, I propose to remove the references to LOGIN_STRING from login.defs file, which in turn, means changing the package to shadow-utils.

Comment 18 errata-xmlrpc 2021-11-09 19:42:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (shadow-utils bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.