Bug 1884846 - Missing icon in gimagereader-qt
Summary: Missing icon in gimagereader-qt
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gimagereader
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-02 23:42 UTC by Peter Simonyi
Modified: 2022-02-07 01:16 UTC (History)
1 user (show)

Fixed In Version: gimagereader-3.4.0-1.fc35
Clone Of:
Environment:
Last Closed: 2022-02-07 01:16:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot on mouse hover (24.19 KB, image/png)
2020-10-03 01:38 UTC, Peter Simonyi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github manisandro gImageReader issues 73 0 None closed Icon is missing in Xfce4 2020-10-28 10:09:54 UTC

Description Peter Simonyi 2020-10-02 23:42:48 UTC
Description of problem:
The toolbar button for 'show output pane' is missing an icon.

Version-Release number of selected component (if applicable):
gimagereader-qt-3.3.1-5.fc33.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Start gImageReader (QT version)
2. Look for the "show output pane" toolbar button.

Actual results:
It's the blank space at the end.

Expected results:
There's actually an icon there.

Additional info:
I'm running F33Beta Workstation (on GNOME).

Comment 1 Peter Simonyi 2020-10-03 01:38:43 UTC
Created attachment 1718567 [details]
screenshot on mouse hover

You can see where it's missing when you hover with the mouse; see screenshot.

Comment 2 Peter Simonyi 2020-10-03 02:25:58 UTC
It seems upstream already found this bug and resolved it by including fallback icons (see https://github.com/manisandro/gImageReader/issues/73).  However, those are not included in the package.

The problem is that gImageReader wants the 'document-edit' icon
 https://github.com/manisandro/gImageReader/blob/master/qt/data/MainWindow.ui#L785
but Adwaita does not provide it (Adwaita has 'document-edit-symbolic').  There may be other missing icons, too, as described in the upstream issue.

It seems like adding a Requires: on the right icon theme would be better than including them in the gimagereader package, but even when I install the Breeze or Oxygen icon themes, gImageReader doesn't use them.

Comment 3 Ben Cotton 2021-11-04 17:30:26 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Peter Simonyi 2021-11-05 17:09:13 UTC
This bug is still present in Fedora 35.

Comment 5 Fedora Update System 2022-01-28 23:35:57 UTC
FEDORA-2022-ff9bcc07c9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ff9bcc07c9

Comment 6 Fedora Update System 2022-01-30 01:14:33 UTC
FEDORA-2022-ff9bcc07c9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-ff9bcc07c9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ff9bcc07c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-02-07 01:16:14 UTC
FEDORA-2022-ff9bcc07c9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.