Bug 1884903 - Gajim 1.2.0 does not include 'plugin_installer' plugin
Summary: Gajim 1.2.0 does not include 'plugin_installer' plugin
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gajim
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Schmidt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-03 12:04 UTC by Illya
Modified: 2021-04-24 22:23 UTC (History)
10 users (show)

Fixed In Version: gajim-1.3.1-1.fc34
Clone Of:
Environment:
Last Closed: 2021-03-23 00:17:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Illya 2020-10-03 12:04:20 UTC
Description of problem:
I have updated from Fedora32 to Fedora33-beta. This includes update from Gajim 1.1.3 to 1.2.0.
After update no plugin could be loaded:

> 03.10.2020 13:00:41 (W) gajim.plugin_system        Plugin without min/max version: plugin_installer
> 03.10.2020 13:00:41 (W) gajim.plugin_system        Plugin message_box_size not loaded, plugin incompatible with current version of gajim: 1.2.0 > 1.1.90
> 03.10.2020 13:00:41 (W) gajim.plugin_system        Plugin clients_icons not loaded, plugin incompatible with current version of gajim: 1.2.0 > 1.1.90
> 03.10.2020 13:00:41 (W) gajim.plugin_system        Plugin omemo not loaded, plugin incompatible with current version of gajim: 1.2.0 > 1.1.90
> 03.10.2020 13:00:41 (W) gajim.plugin_system        Plugin url_image_preview not loaded, plugin incompatible with current version of gajim: 1.2.0 > 1.1.90


Version-Release number of selected component (if applicable):
gajim-1.2.0-2.fc33.noarch

How reproducible:


Steps to Reproduce:
1. Install gajim with some plugins on Fedora version prior to 33
2. Upgrade to Fedora 33
3. Start gajim

Actual results:
No plugin could be loaded

Expected results:
At least plugin_installer should be loaded and capable to update another plugins.

Additional info:

Upstream ticket: https://dev.gajim.org/gajim/gajim-plugins/-/issues/523

Comment 1 Nicolas Berrehouc 2020-11-05 13:54:21 UTC
From a fresh install of Fedora 33 same problem when launching gajim-1.2.0-2.fc33.noarch.

> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin acronyms_expander not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin anti_spam not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin appindicator_integration not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin birthday_reminder not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin clickable_nicknames not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin clients_icons not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin form_handler not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin latex not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin length_notifier not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin message_box_size not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin now_listen not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin omemo not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin openpgp not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin pgp not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin plugin_installer not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin plugins_translations not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin quick_replies not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin regex_filter not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin set_location not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin syntax_highlight not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin tictactoe not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin triggers not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin url_image_preview not loaded, newer version ofgajim required: 1.2.0 < 1.2.91
> 05/11/2020 14:38:52 (W) gajim.plugin_system        Plugin whiteboard not loaded, newer version ofgajim required: 1.2.0 < 1.2.91

Please include Plugin Installer in Gajim package ( https://dev.gajim.org/gajim/gajim-plugins ).

Comment 2 Will Springer 2020-11-10 07:47:45 UTC
The cause seems to be that the Fedora package now fetches source directly from gitlab (dev.gajim.org) instead of the release tarballs on gajim.org, for unknown reasons: https://src.fedoraproject.org/rpms/gajim/c/282be74e92317a25609ddd5338de55626ca3b403?branch=f33

The tarballs published on the website include plugin_installer under gajim/data/plugins (because it bootstraps the user's ability to get plugins), while the source tree lacks that directory entirely (because plugins are managed in the gajim-plugins repository).

Whatever the reasons, the solutions are:
1. Go back to fetching the published tarball (easiest)
2. Add the gajim-plugins gitlab tarball as a source, and only install plugin_installer in the package (somewhat clunky)
3. Create a gajim-plugins subpackage and sidestep the whole thing (more maintenance burden)

Comment 3 wurstsemmel 2020-11-20 09:51:37 UTC
I can confirm that the Plugin Installer is not included in gajim package. As such, I cannot install the Gajim OMEMO Plugin via Plugin Manager.

System: Fedora 33

$ rpm -q gajim
gajim-1.2.0-2.fc33.noarch

Comment 4 wurstsemmel 2020-11-23 11:32:31 UTC
(In reply to wurstsemmel from comment #3)
> As such, I cannot install the Gajim OMEMO Plugin via Plugin Manager.

Just in case somebody else has trouble installing the Plugin Manager manually, please find the steps below:

- Download the folder plugin_installer for the Gajim 1.2 branch here: https://dev.gajim.org/gajim/gajim-plugins/tree/gajim_1.2
- Place the folder into ~/.local/share/gajim/plugins/
- Restart gajim
- Go to Gajim -> Plugins -> Tab Available and install e.g. OMEMO

Note: I tried it with git clone and it did not work as it picks the most current plugin_manager

Comment 5 Russell Odom 2020-11-25 13:59:09 UTC
Quicker and easier fix:
* Download the plugin from https://ftp.gajim.org/plugins_1.2_zip/plugin_installer.zip
* Go to Gajim menu -> Plugins. Click "Install plugin from ZIP-File" icon, bottom left, and select the file you just downloaded
* Click the "Plugin settings" cog icon that now appears for the newly-installed plugin (top right). Enable "Check for updates" and "Update automatically" and after a few seconds, all your existing plugins will be updated.
* Restart Gajim to apply the updates.

Comment 6 Michael Kuhn 2020-12-29 20:52:05 UTC
FYI: I have an open pull request that also fixes this bug: https://src.fedoraproject.org/rpms/gajim/pull-request/2

I have created a scratch build in case you want to give it a try: https://koji.fedoraproject.org/koji/taskinfo?taskID=58562500
You will also need the new version of python-nbxmpp: https://koji.fedoraproject.org/koji/taskinfo?taskID=58562437

Comment 7 Nicolas Berrehouc 2021-01-01 08:45:17 UTC
(In reply to Michael Kuhn from comment #6)
> FYI: I have an open pull request that also fixes this bug:
> https://src.fedoraproject.org/rpms/gajim/pull-request/2
> 
> I have created a scratch build in case you want to give it a try:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=58562500
> You will also need the new version of python-nbxmpp:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=58562437

Great! Works fine for me.

Comment 8 Michael Kuhn 2021-02-21 19:39:35 UTC
FYI, I have created a new PR for Gajim 1.3.0 that also fixes the plugin_installer problem: https://src.fedoraproject.org/rpms/gajim/pull-request/3

There are also scratch builds for Gajim (https://koji.fedoraproject.org/koji/taskinfo?taskID=62451484) and python-nbxmpp (https://koji.fedoraproject.org/koji/taskinfo?taskID=62451121)

Comment 9 Nicolas Berrehouc 2021-02-21 21:20:25 UTC
(In reply to Michael Kuhn from comment #8)
> FYI, I have created a new PR for Gajim 1.3.0 that also fixes the
> plugin_installer problem:
> https://src.fedoraproject.org/rpms/gajim/pull-request/3
> 
> There are also scratch builds for Gajim
> (https://koji.fedoraproject.org/koji/taskinfo?taskID=62451484) and
> python-nbxmpp (https://koji.fedoraproject.org/koji/taskinfo?taskID=62451121)

Nice job! Works fine too.

Comment 10 Fedora Update System 2021-03-18 22:13:29 UTC
FEDORA-2021-1758873b67 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1758873b67

Comment 11 Fedora Update System 2021-03-19 18:45:28 UTC
FEDORA-2021-1758873b67 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-1758873b67`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1758873b67

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Will Springer 2021-03-19 23:58:17 UTC
It seems that plugin_installer missing from the upstream release tarball (as noted by Michael; not the cause of this issue) has been acknowledged[1] and is resolved with the "gajim-1.3.1-2.tar.gz" archive on their site[2] (dated 2 days after 1.3.0 release). Seems like an upstream maintainer mistakenly did the releases with gitlab's generated tarball alone, but the most recent tarball is back to the original format, only containing the tree necessary to package on unices, including bundling plugin_installer.

Additionally, the Fedora packaging guidelines indicate[3] that upstream tarballs are preferable to generated ones, so if you continue to use the gitlab tarball for Source0 then it should probably be commented at least. IMO you should stick with the one hosted on gajim.org/downloads, since at worst it will be the same as the gitlab one and can be worked around accordingly (but hopefully they don't make the same mistake again).

[1]: https://dev.gajim.org/gajim/gajim/-/issues/10467
[2]: https://gajim.org/downloads/1.3/gajim-1.3.1-2.tar.gz
[3]: https://fedoraproject.org/wiki/Packaging:SourceURL

Comment 13 Fedora Update System 2021-03-23 00:17:05 UTC
FEDORA-2021-1758873b67 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Michael Kuhn 2021-04-24 22:23:17 UTC
Thanks for the information! The update to 1.3.2 now uses the proper upstream tarball again.


Note You need to log in before you can comment on or make changes to this bug.