This is a review request for unretiring the package. The original review request is here: https://bugzilla.redhat.com/show_bug.cgi?id=1357110 Spec URL: https://vpv.fedorapeople.org/packages/foma-2020/foma.spec SRPM URL: https://vpv.fedorapeople.org/packages/foma-2020/foma-0.9.18-0.6.20200715git0cd2e4a.fc34.src.rpm Description: Foma can be used for constructing finite-state automata and transducers. It has support for many natural language processing applications such as producing morphological analyzers. It is sufficiently generic to use for a large number of purposes in addition to NLP. The foma interface is similar to the Xerox xfst interface. Fedora Account System Username: vpv Copr: https://copr.fedorainfracloud.org/coprs/vpv/Voikko-4.0/
The standalone spec file and the spec file in the SRPM differ. Could you please synchronize them?
Thank you for noticing. These to should match: SPEC URL: https://vpv.fedorapeople.org/packages/foma-2020/foma.spec SRPM URL: https://vpv.fedorapeople.org/packages/foma-2020/foma-0.9.18-0.8.20200928gitb44022c.fc32.src.rpm
LGTM. - Typo here: Requires: Requires: pkgconfig Remove the extra Requires. - Please add a comment above the patch to justify it [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Package approved. Please fix the aforementioned issue before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/foma See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "GNU General Public License v2.0 or later". 20 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/foma/review-foma/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libfoma [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: foma-0.9.18-0.8.20200928gitb44022c.fc34.x86_64.rpm libfoma-0.9.18-0.8.20200928gitb44022c.fc34.x86_64.rpm libfoma-devel-0.9.18-0.8.20200928gitb44022c.fc34.x86_64.rpm foma-debuginfo-0.9.18-0.8.20200928gitb44022c.fc34.x86_64.rpm foma-debugsource-0.9.18-0.8.20200928gitb44022c.fc34.x86_64.rpm foma-0.9.18-0.8.20200928gitb44022c.fc34.src.rpm foma.x86_64: W: spelling-error %description -l en_US automata -> automate, automaton, automatism foma.x86_64: W: spelling-error %description -l en_US xfst -> fist foma.x86_64: W: no-documentation foma.x86_64: W: no-manual-page-for-binary cgflookup foma.x86_64: W: no-manual-page-for-binary flookup foma.x86_64: W: no-manual-page-for-binary foma libfoma.x86_64: W: spelling-error Summary(en_US) foma -> foam, fora, coma libfoma.x86_64: W: spelling-error %description -l en_US Foma -> Coma, Foam, Fora libfoma.x86_64: W: spelling-error %description -l en_US automata -> automate, automaton, automatism libfoma.x86_64: W: spelling-error %description -l en_US foma -> foam, fora, coma libfoma.x86_64: W: spelling-error %description -l en_US xfst -> fist libfoma.x86_64: W: shared-lib-calls-exit /usr/lib64/libfoma.so.0.9.18 exit.5 libfoma-devel.x86_64: W: no-documentation foma.src: W: spelling-error %description -l en_US automata -> automate, automaton, automatism foma.src: W: spelling-error %description -l en_US xfst -> fist 6 packages and 0 specfiles checked; 0 errors, 15 warnings.
Thank you for the review! I ended up simplifying the patch after going through the build process once again. I also added a comment on why the patch is needed. Nice catch on the copy-paste typo. For some reason rpmlint did not catch it. Updated SPEC: https://vpv.fedorapeople.org/packages/foma-2020/foma.spec SRPM: https://vpv.fedorapeople.org/packages/foma-2020/foma-0.9.18-0.9.20200928gitb44022c.fc32.src.rpm As this is an unretirement review request, I'll have to do some reading on how to proceed from here.
Built in Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=56075563 For some reason I did not get an F33 branch during unretirement. I've asked for that here: https://pagure.io/releng/fedora-scm-requests/issue/30842 I am closing this bug report now. Thank you for your help, Robert-André and Petr.