Bug 188507 - john does not compile with libc-headers-2.4-4
Summary: john does not compile with libc-headers-2.4-4
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: john
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Till Maas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-ia64
TreeView+ depends on / blocked
 
Reported: 2006-04-10 18:42 UTC by Prarit Bhargava
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-03-04 20:30:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to fix CLK_TCK usage (1.83 KB, patch)
2006-04-10 18:42 UTC, Prarit Bhargava
no flags Details | Diff

Description Prarit Bhargava 2006-04-10 18:42:02 UTC
Description of problem:  
  
john does not compile with libc-headers-2.4-4 which ships with FC5 due to  
erroneous usage of CLK_TCK. 
  
Version-Release number of selected component (if applicable):  
 john-1.6-4.src.rpm 
  
How reproducible: 100% 
  
  
Steps to Reproduce:  
1. rpmbuild --rebuild source rpm or rpmbuild -bb spec.file 
    
Actual results:  Build fails. 
  
bench.c: In function âbenchmark_formatâ: 
bench.c:106: error: âCLK_TCKâ undeclared (first use in this function) 
bench.c:106: error: (Each undeclared identifier is reported only once 
bench.c:106: error: for each function it appears in.) 
bench.c: In function âbenchmark_cpsâ: 
bench.c:147: error: âCLK_TCKâ undeclared (first use in this function) 
make[1]: *** [bench.o] Error 1 
make[1]: Leaving directory `/usr/src/redhat/BUILD/john-1.6-orig/src' 
make: *** [generic.h] Error 1 
 
 
Expected results:  
  
Build should succeed. 
 
Additional info: CLK_TCK should be replaced with CLOCKS_PER_SEC. 
Patch attached.

Comment 1 Prarit Bhargava 2006-04-10 18:42:02 UTC
Created attachment 127566 [details]
Patch to fix CLK_TCK usage

Comment 2 Till Maas 2007-01-10 15:02:16 UTC
In extras-development there is now john-1.7.0.2-2

It uses:

#if defined(_SC_CLK_TCK) || !defined(CLK_TCK)
        clk_tck = sysconf(_SC_CLK_TCK);
#else
        clk_tck = CLK_TCK;
#endif
}

does this work for you or is this still wrong?

Comment 3 Till Maas 2007-02-26 23:43:26 UTC
I will assume the bug is fixed when you do not respond soon.

Comment 4 Till Maas 2007-03-04 20:30:40 UTC
assumed to be fixed, please reopen when you have additional info and the bug is
still present.


Note You need to log in before you can comment on or make changes to this bug.