Bug 1885170 - Nil pointer when verifying images
Summary: Nil pointer when verifying images
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 4.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.7.0
Assignee: Maciej Szulik
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks: 1885959
TreeView+ depends on / blocked
 
Reported: 2020-10-05 10:33 UTC by Maciej Szulik
Modified: 2021-02-24 15:23 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Missing image verifier object wiring in code. Consequence: There was a code path which lead to oc failing with nil pointer exception. Fix: Wire all the necessary bits in the code, here rejection image verifier. Result: oc is working without problems.
Clone Of:
: 1885959 (view as bug list)
Environment:
Last Closed: 2021-02-24 15:22:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift oc pull 603 0 None closed Bug 1885170: fix nil pointer in release code 2021-02-11 15:20:34 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:23:05 UTC

Description Maciej Szulik 2020-10-05 10:33:28 UTC
See https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-aws-mirrors-4.6/1312810584852402176 

warning: No release authenticity verification is configured, all releases are considered unverified
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x22993ba]

goroutine 1 [running]:
github.com/openshift/library-go/pkg/verify.(*ReleaseVerifier).Verify(0x0, 0x34ed9c0, 0xc00360e100, 0x0, 0x0, 0x0, 0x0)
	/go/src/github.com/openshift/oc/vendor/github.com/openshift/library-go/pkg/verify/verify.go:132 +0x3a
github.com/openshift/oc/pkg/cli/admin/release.(*MirrorOptions).Run(0xc001316200, 0x0, 0x0)
	/go/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go:519 +0x72c
github.com/openshift/oc/pkg/cli/admin/release.(*NewOptions).mirrorImages(0xc0015b8a00, 0xc0003ac900, 0xc0024b5600, 0x4d604e0)
	/go/src/github.com/openshift/oc/pkg/cli/admin/release/new.go:1060 +0x219
github.com/openshift/oc/pkg/cli/admin/release.(*NewOptions).Run(0xc0015b8a00, 0x0, 0x0)
	/go/src/github.com/openshift/oc/pkg/cli/admin/release/new.go:705 +0x1b2e
github.com/openshift/oc/pkg/cli/admin/release.NewRelease.func1(0xc0017abb80, 0xc001824e40, 0x0, 0x6)
	/go/src/github.com/openshift/oc/pkg/cli/admin/release/new.go:114 +0xd3
github.com/spf13/cobra.(*Command).execute(0xc0017abb80, 0xc001824de0, 0x6, 0x6, 0xc0017abb80, 0xc001824de0)
	/go/src/github.com/openshift/oc/vendor/github.com/spf13/cobra/command.go:846 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xc00157a2c0, 0x2, 0xc00157a2c0, 0x2)
	/go/src/github.com/openshift/oc/vendor/github.com/spf13/cobra/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/go/src/github.com/openshift/oc/vendor/github.com/spf13/cobra/command.go:887
main.main()
	/go/src/github.com/openshift/oc/cmd/oc/oc.go:110 +0x885
ignore: the release could not be reproduced from its inputs
error: unable to retrieve release image info: unable to read image registry.svc.ci.openshift.org/ci-op-zgjy6n80/release-scratch:release: name unknown

Comment 5 errata-xmlrpc 2021-02-24 15:22:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.