Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1885355

Summary:	ironic agent token is not regenerated after introspection or cleaning fails
Product:	OpenShift Container Platform	Reporter:	Bob Fournier <bfournie>
Component:	Bare Metal Hardware Provisioning	Assignee:	Dmitry Tantsur <dtantsur>
Bare Metal Hardware Provisioning sub component:	ironic	QA Contact:	Raviv Bar-Tal <rbartal>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	high
Priority:	high	Keywords:	Triaged
Version:	4.6
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-02 16:36:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bob Fournier 2020-10-05 17:50:40 UTC

Description of problem:

We've seen problems where the ironic agent token is not regenerated when either introspection or cleaning fails, and is then rerun.

We see this error in the conductor logs:
Aug 31 14:56:05 hardprov-dl360-g9-01.snedlab.lab.eng.rdu2.redhat.com ironic-conductor[123104]: 2020-08-31 14:56:05.796 123104 WARNING ironic.conductor.manager [req-6f1752c3-6185-4ac4-89fa-b0fe1a0ad604 - - - - -] An agent token generation request is being refused as one is already present for node 32e4070b-e56d-4444-8d58-678a4649d321

And these errors in the ironic api logs:
Aug 31 14:56:06 hardprov-dl360-g9-01.snedlab.lab.eng.rdu2.redhat.com ironic-conductor[123104]: 2020-08-31 14:56:06.130 123104 ERROR ironic.conductor.manager [req-7c7036b7-92af-4093-a18c-6bfd3fbc5e3c - - - - -] Suspicious activity detected for node 32e4070b-e56d-4444-8d58-678a4649d321 when attempting to heartbeat. Heartbeat request has been rejected as the version of ironic-python-agent indicated in the heartbeat operation should support agent token functionality.
Aug 31 14:58:32 hardprov-dl360-g9-01.snedlab.lab.eng.rdu2.redhat.com ironic-conductor[123104]: 2020-08-31 14:58:32.152 123104 ERROR ironic.conductor.manager [req-d1f795a2-99f2-4b3c-9e71-5ffa52758868 - - - - -] Suspicious activity detected for node 32e4070b-e56d-4444-8d58-678a4649d321 when attempting to heartbeat. Heartbeat request has been rejected as the version of ironic-python-agent indicated in the heartbeat operation should support agent token functionality.

Comment 1 Bob Fournier 2020-10-26 12:10:09 UTC

Fix has merged to stable/victoria.  When 4.7 builds are done this will be picked up.

Comment 2 Dmitry Tantsur 2020-11-17 12:20:52 UTC

I believe the fix is available now