Bug 1886214 - Need to disable HTX when not using HTTP/2 in order to preserve HTTP header name case
Summary: Need to disable HTX when not using HTTP/2 in order to preserve HTTP header na...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.5.z
Assignee: Miciah Dashiel Butler Masters
QA Contact: Hongan Li
URL:
Whiteboard:
Depends On: 1886213
Blocks: 1886215
TreeView+ depends on / blocked
 
Reported: 2020-10-07 23:41 UTC by OpenShift BugZilla Robot
Modified: 2022-08-04 22:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-08 18:26:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift router pull 200 0 None closed [release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2 2021-02-16 16:34:06 UTC
Red Hat Product Errata RHBA-2020:5250 0 None None None 2020-12-08 18:26:20 UTC

Comment 1 Miciah Dashiel Butler Masters 2020-10-26 05:20:54 UTC
Fix is posted but blocked on verification of the 4.6.z backport and will need cherry-pick-approved label.

Comment 2 Miciah Dashiel Butler Masters 2020-11-14 00:50:00 UTC
The bump to HAProxy 2.2 may block this change if the bump affects OCP 4.5 because HAProxy 2.2 removes the "http-use-htx" option (see bug 1897039).  Need to investigate in the upcoming sprint.

Comment 3 Miciah Dashiel Butler Masters 2020-11-16 22:00:35 UTC
(In reply to Miciah Dashiel Butler Masters from comment #2)
> The bump to HAProxy 2.2 may block this change if the bump affects OCP 4.5
> because HAProxy 2.2 removes the "http-use-htx" option (see bug 1897039). 
> Need to investigate in the upcoming sprint.

The bump to HAProxy 2.2 only affects OpenShift 4.7 because it requires a change to the Dockerfiles, and that change has not been backported to earlier release branches, so we can go ahead with turning off HTX in 4.5.

Comment 4 Hongan Li 2020-11-25 06:03:10 UTC
verified with 4.5 cluster (4.5.0-0.ci.test-2020-11-25-031041-ci-ln-12r8cik) launched by cluster-bot and passed

sh-4.2$ printenv | grep -i http2
ROUTER_DISABLE_HTTP2=true
sh-4.2$ 
sh-4.2$ cat haproxy.config | grep htx
  no option http-use-htx
sh-4.2$ 
sh-4.2$ haproxy -v
HA-Proxy version 2.0.14 2020/04/02 - https://haproxy.org/
sh-4.2$ 

# curl http://router-headers.example.com --resolve "router-headers.example.com:80:34.74.176.177" -H X-foo:foo -H X-Bar:Bar -H X-BaZ:BaZ
GET / HTTP/1.1
User-Agent: curl/7.61.1
Accept: */*
X-foo:foo
X-Bar:Bar
X-BaZ:BaZ
Host: router-headers.example.com
X-Forwarded-Host: router-headers.example.com
X-Forwarded-Port: 80
X-Forwarded-Proto: http
Forwarded: for=66.187.232.129;host=router-headers.example.com;proto=http
X-Forwarded-For: 66.187.232.129

Comment 8 errata-xmlrpc 2020-12-08 18:26:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5.22 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5250


Note You need to log in before you can comment on or make changes to this bug.