Bug 1886301 - openMSX update request, new upstream version
Summary: openMSX update request, new upstream version
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openmsx
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-08 06:54 UTC by Robert
Modified: 2020-10-26 01:22 UTC (History)
1 user (show)

Fixed In Version: openmsx-16.0-1.fc33 openmsx-16.0-1.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-23 22:17:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Robert 2020-10-08 06:54:56 UTC
Description of problem:
A new version of openMSX (and the associated catapult launcher) has been released.
https://github.com/openMSX/openMSX/releases/tag/RELEASE_16_0

This is a request to update to the latest version. This release will require some additional changes to the spec file as the project has migrated to SDL2, and it should no longer need the python3 patch.

Version-Release number of selected component (if applicable):
openmsx
openmsx-catapult

Additional info:

release notes

openMSX 16.0—Oh Shucks—is a major release in which we finally migrated to SDL2 and Tcl 8.6. And we moved to a simpler versioning scheme, stripping off that 0. prefix now :) Other than that, there are loads and loads of improvements. Some often requested ones are copy/paste functionality and drag and drop support. But we also added a super accurate YM2413 emulation (originally written by NukeYKT), fixed MIDI-in/out support on Windows, a new keyboard mode, much improved OSD menu, etc. Together with openMSX an updated version of Catapult, our user-friendly GUI, was released. We again made a small amount of improvements: fix hidden openMSX window when launching from Catapult, migration to Python 3 and wxWidgets 3.0, make supported extensions consistent with openMSX command line, replaced Accuracy control with VSync button and Min and Max Frameskip controls with fast forward speed controls and added a button to enable full speed when loading ("Fast Load"). Please read the release notes for details of the openMSX changes.

Comment 1 Robert 2020-10-16 13:59:09 UTC
FYI, I am trying to push some cleanups upstream such that "make install" will actually install the icons and an updated desktop file in the right location, in addition to a metainfo.xml.

Two comments to the current rpm spec file.

The openMSX license is actually GPL2 not GPL+ or GPL2+. e.g.
- License:        GPL+
- <project_license>GPL-2.0+</project_license>

Both are incorrect, and they should be changed respectively to:
- License:        GPLv2
- <project_license>GPL-2.0</project_license>



Also, can you change "<summary>Emulate all aspects of the MSX with 100% accuracy</summary>"
to: "<summary>Emulate all aspects of the MSX with high accuracy</summary>"?

100% accuracy is obviously unattainable :-)

Comment 2 Hans de Goede 2020-10-16 14:09:20 UTC
Thanks for the various suggestions/corrections. I will incorporate those when I can find some time to update Fedora's openMSX packages.

Note if you already are a Fedora packager then I would certainly welcome a co-maintainer.

Comment 3 Robert 2020-10-16 14:52:01 UTC
Hi Hans,

I have experience with RPM packaging in a corporate environment, and have a fully setup fedoraproject account and am fairly familiar with git.

I have however never done Koji, but am willing to give it a try.

Comment 4 Robert 2020-10-16 15:43:08 UTC
I have just submitted a koji build for 16.0
https://koji.fedoraproject.org/koji/taskinfo?taskID=53596634

Comment 5 Robert 2020-10-16 16:12:04 UTC
Build was a success.

spec file changelog
- bump version to 16.0
- Change license to GPLv2
- Adjust buildrequires
- remove no longer needed patches
- change http to https
- adjust some descriptions
- update changelog

Comment 6 Robert 2020-10-17 07:37:35 UTC
If it helps, here is the spec file diff

$ diff openmsx.spec.org openmsx.spec
2,3c2,3
< Version:        0.15.0
< Release:        6%{?dist}
---
> Version:        16.0
> Release:        1%{?dist}
5,11c5,8
< License:        GPL+
< URL:            http://openmsx.org/
< Source0:        https://github.com/openMSX/openMSX/releases/download/RELEASE_0_15_0/%{name}-%{version}.tar.gz
< Source1:        https://github.com/openMSX/openMSX/releases/download/RELEASE_0_15_0/%{name}-catapult-%{version}.tar.gz
< Patch1:         openmsx-0.15.0-archs.patch
< Patch2:         openmsx-0.15.0-convert-build-to-python3.patch
< Patch3:         openmsx-catapult-0.15.0-python3-build-fix.patch
---
> License:        GPLv2
> URL:            https://openmsx.org/
> Source0:        https://github.com/openMSX/openMSX/releases/download/RELEASE_16_0/%{name}-%{version}.tar.gz
> Source1:        https://github.com/openMSX/openMSX/releases/download/RELEASE_16_0/%{name}-catapult-%{version}.tar.gz
15c12
< BuildRequires:  glew-devel >= 1.3.2
---
> BuildRequires:  glew-devel >= 2.1.0
19,20c16,17
< BuildRequires:  SDL_image-devel SDL_ttf-devel freetype-devel
< BuildRequires:  tcl-devel >= 8.4.0
---
> BuildRequires:  SDL2_image-devel SDL2_ttf-devel freetype-devel
> BuildRequires:  tcl-devel >= 8.6.0
32c29
< all aspects of the MSX with 100% accuracy. In addition to emulating MSX, MSX2,
---
> all aspects of the MSX with high accuracy. In addition to emulating MSX, MSX2,
39c36
< Summary:        Graphical interface for openMSX
---
> Summary:        Graphical front-end for openMSX
166c163
<   <project_license>GPL-2.0+</project_license>
---
>   <project_license>GPL-2.0</project_license>
219a217,219
> * Fri Oct 16 2020 Robert de Rooy <robert.de.rooy> - 16.0-1
> - New upstream version 16.0 (rhbz#1886301)
>

Comment 7 Hans de Goede 2020-10-18 12:22:28 UTC
Thank you. I've prepared a new version based on the srpm which you uploaded to koji. I'll submit an update for F32+ based on this new version soon.

p.s. you missed one case of 100% accuracy in the appdata file, I've fixed that one up too.

Comment 8 Fedora Update System 2020-10-18 12:24:18 UTC
FEDORA-2020-443a22cdf3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-443a22cdf3

Comment 9 Fedora Update System 2020-10-18 12:24:18 UTC
FEDORA-2020-4ba7e36a5e has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ba7e36a5e

Comment 10 Fedora Update System 2020-10-18 15:50:16 UTC
FEDORA-2020-443a22cdf3 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-443a22cdf3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-443a22cdf3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-10-18 19:25:10 UTC
FEDORA-2020-4ba7e36a5e has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4ba7e36a5e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ba7e36a5e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-10-23 22:17:06 UTC
FEDORA-2020-4ba7e36a5e has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-10-26 01:22:58 UTC
FEDORA-2020-443a22cdf3 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.