Spec URL: https://javierm.fedorapeople.org/pkgs/rust-serial_test_derive/rust-serial_test_derive.spec SRPM URL: https://javierm.fedorapeople.org/pkgs/rust-serial_test_derive/rust-serial_test_derive-0.5.0-1.fc34.src.rpm Description: Helper crate for serial_test. Fedora Account System Username: javierm
Package APPROVED, but please note the failed SHOULD item below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== ISSUES ====== SHOULD: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please notify upstream that they should include the LICENSE file in the _derive sub-crate as well, and put a comment with a link to the upstream issue into the .spec file. Most of the time, this can be accomplished by adding a symlink like `LICENSE → ../LICENSE` in the sub-crate. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/deca/Downloads/1886458-rust- serial_test_derive/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-serial_test_derive-devel-0.5.0-1.fc34.noarch.rpm rust-serial_test_derive+default-devel-0.5.0-1.fc34.noarch.rpm rust-serial_test_derive-0.5.0-1.fc34.src.rpm rust-serial_test_derive-devel.noarch: W: invalid-url URL: https://crates.io/crates/serial_test_derive HTTP Error 404: Not Found rust-serial_test_derive-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/serial_test_derive-0.5.0/.cargo-checksum.json rust-serial_test_derive+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/serial_test_derive HTTP Error 404: Not Found rust-serial_test_derive+default-devel.noarch: W: no-documentation rust-serial_test_derive.src: W: invalid-url URL: https://crates.io/crates/serial_test_derive HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- rust-serial_test_derive+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/serial_test_derive <urlopen error [Errno -3] Temporary failure in name resolution> rust-serial_test_derive+default-devel.noarch: W: no-documentation rust-serial_test_derive-devel.noarch: W: invalid-url URL: https://crates.io/crates/serial_test_derive <urlopen error [Errno -3] Temporary failure in name resolution> rust-serial_test_derive-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/serial_test_derive-0.5.0/.cargo-checksum.json 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Source checksums ---------------- https://crates.io/api/v1/crates/serial_test_derive/0.5.0/download#/serial_test_derive-0.5.0.crate : CHECKSUM(SHA256) this package : 65f59259be9fc1bf677d06cc1456e97756004a1a5a577480f71430bd7c17ba33 CHECKSUM(SHA256) upstream package : 65f59259be9fc1bf677d06cc1456e97756004a1a5a577480f71430bd7c17ba33 Requires -------- rust-serial_test_derive-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) < 2.0.0) (crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0) (crate(syn/default) >= 1.0.0 with crate(syn/default) < 2.0.0) (crate(syn/full) >= 1.0.0 with crate(syn/full) < 2.0.0) cargo rust-serial_test_derive+default-devel (rpmlib, GLIBC filtered): cargo crate(serial_test_derive) Provides -------- rust-serial_test_derive-devel: crate(serial_test_derive) rust-serial_test_derive-devel rust-serial_test_derive+default-devel: crate(serial_test_derive/default) rust-serial_test_derive+default-devel Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -o --enablerepo local -b 1886458 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, PHP, Java, Haskell, Python, fonts, Perl, R, Ocaml, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Fabio Valentini from comment #1) Thanks a lot for the review! [snip] > > SHOULD: > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > Please notify upstream that they should include the LICENSE file in the > _derive Proposed fix merged at https://github.com/palfrey/serial_test/commit/4997bc3d56d. > sub-crate as well, and put a comment with a link to the upstream issue into > the > .spec file. Most of the time, this can be accomplished by adding a symlink > like > `LICENSE → ../LICENSE` in the sub-crate. > Also added a comment in the .spec file referencing that upstream commit. Both the .spec file and SRPM mentioned in Description have been updated. It would be great if you could also review Bug 1886463 that's blocked by this.
Sure, I'll do the other review once this package has been imported and built.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serial_test_derive
(In reply to Fabio Valentini from comment #3) > Sure, I'll do the other review once this package has been imported and built. Thanks. Packaged imported [0] and built [1]. [0]: https://src.fedoraproject.org/rpms/rust-serial_test_derive [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=53910334
*** Bug 1907015 has been marked as a duplicate of this bug. ***