Bug 1886700 - Review Request: golang-github-saintfish-chardet - Charset detector library
Summary: Review Request: golang-github-saintfish-chardet - Charset detector library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-09 07:11 UTC by Fabian Affolter
Modified: 2021-03-16 18:14 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-03-16 18:14:07 UTC
Type: Bug
Embargoed:
o.lemasle: fedora-review+

Attachments (Terms of Use)

Description Fabian Affolter 2020-10-09 07:11:06 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chardet.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chardet-0-0.1.20201009git3af4cd4.fc32.src.rpm

Project URL: https://github.com/saintfish/chardet

Description:
Charset detector library for Golang derived from ICU.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=53063210

rpmlint output:
$ rpmlint golang-github-saintfish-chardet-0-0.1.20201009git3af4cd4.fc32.src.rpm 
golang-github-saintfish-chardet.src: W: spelling-error Summary(en_US) Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet.src: W: spelling-error %description -l en_US Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint golang-github-saintfish-chardet-devel-0-0.1.20201009git3af4cd4.fc32.noarch.rpm 
golang-github-saintfish-chardet-devel.noarch: W: spelling-error Summary(en_US) Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet-devel.noarch: W: spelling-error %description -l en_US Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/saintfish/chardet/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab
Comment 1 Olivier Lemasle 2020-10-29 17:33:14 UTC 
I think "icu-license.html" should be added in golicenses. It contains the ICU license and it is referenced at the end of "LICENSE".
Comment 2 Fabian Affolter 2020-12-11 21:44:58 UTC 
(In reply to Olivier Lemasle from comment #1)
> I think "icu-license.html" should be added in golicenses. It contains the
> ICU license and it is referenced at the end of "LICENSE".

Added

%changelog
* Fri Dec 11 2020 Fabian Affolter <mail> - 0-0.2.20201009git3af4cd4
- Add missing license file (#1887671)

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chardet.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chardet-0-0.2.20201009git3af4cd4.fc33.src.rpm
Comment 3 Olivier Lemasle 2020-12-19 18:29:23 UTC 
Ok thanks, package accepted.

- licence ok
- spec ok
- naming ok
- rpmlint ok
Comment 4 Fabian Affolter 2020-12-21 08:06:29 UTC 
Thanks for the review.
Comment 5 Gwyn Ciesla 2020-12-21 14:16:37 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-saintfish-chardet
Note You need to log in before you can comment on or make changes to this bug.