Bug 1886861 - ordered-values.yaml not honored if values.schema.json provided
Summary: ordered-values.yaml not honored if values.schema.json provided
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.7.0
Assignee: Rohit Rai
QA Contact: Gajanan More
Rishu Mehra
URL:
Whiteboard:
Depends On:
Blocks: 1897043
TreeView+ depends on / blocked
 
Reported: 2020-10-09 14:38 UTC by morstad
Modified: 2021-03-10 09:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Previously, in the *YAML view* of the Helm installation form only the YAML schema or code was shown. There was no option to provide and view comments with parameters. Now you can view parameters in a defined order with comments. A *Schema* viewer is added to the page, next to the *YAML* editor to check all the schema objects present in the Helm Chart. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1886861[BZ#1886861])
Clone Of:
: 1897043 (view as bug list)
Environment:
Version: 4.6.0-0.nightly-2020-10-03-051134 Cluster ID: d189d8ef-1961-4aff-b73c-afbf2ead94ff Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36
Last Closed: 2021-02-24 15:24:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screen shot of schema display during operator CR install via YAML view (314.75 KB, image/png)
2020-10-14 11:42 UTC, morstad
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:24:54 UTC

Description morstad 2020-10-09 14:38:37 UTC
Description of problem:
Order of parameters with comments can be specified via ordered-values.yaml.  This is required when installing via YAML view as need way to have comments with parameters (i.e. Provided link to license accepting via comment).  In 4.6 support for 'Form View' was provided if specify values.schema.json, but user can still switch to 'YAML View'.  Need comments and parameter order to be maintained in 4.6 if switch to 'YAML View' - honor ordered-values.yaml which is NOT happening..


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Log into 4.6 nightly build cluster
2. Navigate to Developer Catalog -> +Add -> Helm Chart
3. Select Ibm Oms Ent Prod v5.1.0 chart
4. Click 'Install Helm Chart'
5. Switch to 'YAML View'

Actual results:
See parameters from values.yaml in alphabetical order without comments

Expected results:
See parameters in defined order in ordered-values.yaml with comments

Additional info:

Comment 1 Stephen Cuppett 2020-10-09 16:56:11 UTC
Setting target release to the active development branch (4.7.0). For any fixes, where required and requested, cloned BZs will be created for those release maintenance streams where appropriate once they are identified.

Comment 2 morstad 2020-10-14 11:41:18 UTC
Alternative to supporting ordered-values.yaml would be to be consistent with operator CR approach where schema is shown on right side when using YAML view install (see attachment)

Comment 3 morstad 2020-10-14 11:42:06 UTC
Created attachment 1721446 [details]
Screen shot of schema display during operator CR install via YAML view

Comment 4 Rohit Rai 2020-10-20 17:10:38 UTC
Agreed, having a schema viewer along with YAML editor would make the experience consistent with operator backed forms.

Comment 5 Andrew Ballantyne 2020-10-23 17:17:56 UTC
Tracked in Jira for planning purposes: https://issues.redhat.com/browse/ODC-5041

Comment 6 Rohit Rai 2020-11-12 07:19:53 UTC
Verified on 4.7.0-0.nightly-2020-11-12-005200

Comment 9 errata-xmlrpc 2021-02-24 15:24:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633

Comment 10 Rishu Mehra 2021-03-03 20:50:42 UTC
Updated the Doc_text field for the Release Notes.


Note You need to log in before you can comment on or make changes to this bug.