Bug 1887057 - Icons are dark in dark mode and are barely readable
Summary: Icons are dark in dark mode and are barely readable
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: xournalpp
Version: 32
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Luya Tshimbalanga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-10 12:21 UTC by Eric L.
Modified: 2020-10-10 18:19 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-10-10 18:19:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Light icon displayed on dark background (60.41 KB, image/png)
2020-10-10 17:57 UTC, Luya Tshimbalanga
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github xournalpp xournalpp issues 1746 0 None open Dark theme not working 2020-10-10 12:21:15 UTC

Description Eric L. 2020-10-10 12:21:15 UTC
Description of problem:
When using a GTK dark theme, the icons in Xournalpp remain dark even if selecting the dark mode of Xournalpp. The problem is known upstream and already fixed in the code, due for 1.1.0, but it would be nice to get the fix back-ported as the UI is currently barely readable in dark mode.

Version-Release number of selected component (if applicable):

$ rpm -qa | grep xournal
xournalpp-plugins-1.0.18-2.fc32.noarch
xournalpp-1.0.18-2.fc32.x86_64
xournalpp-ui-1.0.18-2.fc32.noarch

How reproducible:

Always.

Steps to Reproduce:
1. Set dark mode in GTK (e.g. using Theme Mint-Y-Dark-Aqua under Cinnamon, but other dark themes have the same issue)
2. Start xournalpp
3. Set Edit -> Preferences... -> View -> Global -> Dark Theme (require restart)
4. Restart xournalpp

Actual results:

Many icons of Xournalpp are dark on dark and barely readable, independently of the dark setting in the preferences.

Expected results:

All icons are light so that they are visible on dark theme.

Additional info:

The issue is described at https://github.com/xournalpp/xournalpp/issues/1746 and this aspect solved in PR https://github.com/xournalpp/xournalpp/pull/1767

Comment 1 Luya Tshimbalanga 2020-10-10 17:57:19 UTC
Created attachment 1720458 [details]
Light icon displayed on dark background

Comment 2 Luya Tshimbalanga 2020-10-10 18:19:07 UTC
Hello Eric,

As you notice on comment #1 and the solved PR, the fix is already applied on 1.0.18.
Because the issue related to icons is upstream, it will be better to report on that ticket https://github.com/xournalpp/xournalpp/pull/1735

You can also test the snapshot on https://copr.fedorainfracloud.org/coprs/luya/xournalpp/package/xournalpp/ and let know about the difference for possible port.

I am closing this as upstream but feel free to reopen.


Note You need to log in before you can comment on or make changes to this bug.