Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://people.parinux.org/~seyman/fedora/perl-Test2-Tools-PerlCritic/perl-Test2-Tools-PerlCritic.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Test2-Tools-PerlCritic/perl-Test2-Tools-PerlCritic-0.03-1.fc32.src.rpm Description: Test for Perl::Critic violations using Test2. Although this testing tool uses the Test2 API instead of the older Test::Builder API, the primary motivation is to provide output in a more useful form. That is policy violations are grouped by policy class, and the policy class name is clearly displayed as a diagnostic. The author finds the former more useful because he tends to address one type of violation at a time. The author finds the latter more useful because he tends to want to lookup or adjust the configuration of the policy as he is addressing violations. Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Please add build-requires perl-generators - package does not list all Perl run-time dependencies and it relies on the generators perl-interpreter - perl-Test2-Tools-PerlCritic.spec:48 make - perl-Test2-Tools-PerlCritic.spec:49 - The macro is provided by rpm that does not depend on make TODO: Please use 'perl(:VERSION) >= 5.20' instead of 'perl >= 0:5.020'. The package 'perl' install interpreter and all core modules. It is not needed. $ rpm -qp --requires perl-Test2-Tools-PerlCritic-0.03-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(:MODULE_COMPAT_5.32.0) FIX: Build-require 'perl-generators' $ rpm -qp --provides perl-Test2-Tools-PerlCritic-0.03-1.fc34.noarch.rpm | sort | uniq -c 1 perl-Test2-Tools-PerlCritic = 0.03-1.fc34 FIX: Build-require 'perl-generators' $ rpmlint ./perl-Test2-Tools-PerlCritic* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT approved
Oops. Spec URL: https://people.parinux.org/~seyman/fedora/perl-Test2-Tools-PerlCritic/perl-Test2-Tools-PerlCritic.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Test2-Tools-PerlCritic/perl-Test2-Tools-PerlCritic-0.03-2.fc32.src.rpm
> FIX: Please add build-requires > perl-generators - package does not list all Perl run-time dependencies > and it relies on the generators > perl-interpreter - perl-Test2-Tools-PerlCritic.spec:48 > make - perl-Test2-Tools-PerlCritic.spec:49 - The macro is provided by > rpm that does not depend on make > TODO: Please use 'perl(:VERSION) >= 5.20' instead of 'perl >= 0:5.020'. > The package 'perl' install interpreter and all core modules. > It is not needed. -BuildRequires: perl >= 0:5.020 # build requirements +BuildRequires: make +BuildRequires: perl-generators +BuildRequires: perl-interpreter >= 5.20 Ok Resolution: Approved
> BuildRequires: perl-interpreter >= 5.20 The package has an epoch. Comparing perl(-interprerer) RPM version against Perl laguage version completely misses the point. If you really need to check for the Perl language version, use perl(:VERSION).
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Tools-PerlCritic