Bug 1887188 - Review Request: perl-Test-Snapshot - Test against data stored in automatically-named file
Summary: Review Request: perl-Test-Snapshot - Test against data stored in automaticall...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-11 16:54 UTC by Emmanuel Seyman
Modified: 2020-10-26 09:06 UTC (History)
2 users (show)

Fixed In Version: perl-Test-Snapshot-0.06-1.fc34
Clone Of:
Environment:
Last Closed: 2020-10-26 09:06:23 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2020-10-11 16:54:09 UTC
Spec URL: https://people.parinux.org/~seyman/fedora/perl-Test-Snapshot/perl-Test-Snapshot.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-Test-Snapshot/perl-Test-Snapshot-0.06-1.fc32.src.rpm
Description:
Not connected with Test::Snapshots, which is based on a similar concept but
for running executables.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2020-10-12 14:10:49 UTC
Source file is ok
Summary is ok
License is ok
Description is ok

URL and Source0 
FIX: Please use link to metacpan.org
    URL: https://metacpan.org/release/Test-Snapshot
    Source1: https://cpan.metacpan.org/authors/id/E/ET/ETJ/Test-Snapshot-%{version}.tar.gz

All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-Snapshot-0.06-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Exporter)
      1 perl(File::Basename)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(Test2::API)
      1 perl(Test::More)
      1 perl(Text::Diff)
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Snapshot-0.06-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Test::Snapshot) = 0.06
      1 perl-Test-Snapshot = 0.06-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Test-Snapshot*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2020-10-12 21:32:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Snapshot


Note You need to log in before you can comment on or make changes to this bug.