Spec URL: https://www.cora.nwra.com/~orion/fedora/python-pytest-mpi.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/python-pytest-mpi-0.4-1.fc34.src.rpm Description: ytest_mpi is a plugin for pytest providing some useful tools when running tests under MPI, and testing MPI-related code. Fedora Account System Username: orion Needed for h5py 3.0.0
Package seems to bundle python-versioneer: https://github.com/python-versioneer/python-versioneer could this be removed and add dep on: http://rpms.remirepo.net/rpmphp/zoom.php?rpm=python-versioneer The bundled file is also Public Domain not as BSD as the rest. fedora-review says: Package must not depend on deprecated() packages. Note: python3-pytest4 is deprecated, you must not depend on it. but I can't see this is true, comment? - Fix perm on 12.patch set it to 0644, not 0660. -Fix URL: URL: https://pytest-mpi.readthedocs.io/en/latest/ use: https://github.com/aragilar/pytest-mpi Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest4 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pytest-mpi-0.4-1.fc34.noarch.rpm python-pytest-mpi-0.4-1.fc34.src.rpm python-pytest-mpi.src: W: strange-permission 12.patch 660 Set perms to 644. Rpmlint (installed packages)
Actually, it appears that the way versioneer is supposed to be used is you run "versioneer install" and commit the results to your repo. I think that is what the included versioneer.py file is. I also think since versioneer.py is not shipped it doesn't affect the license of pytest-mpi. The pytest4 seems like more of a fedora review bug. I can't find any reference to that in this code. * Sun Nov 1 2020 Orion Poplawski <orion> - 0.4-2 - Change URL - Fix permissions Spec URL: https://www.cora.nwra.com/~orion/fedora/python-pytest-mpi.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/python-pytest-mpi-0.4-2.fc34.src.rpm
All fixed. Package is APPROVED.
Thanks for the review. Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/30189
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-mpi
Checked in and built.