Bug 1887426 - rpminspect-data-fedora is missing a dependency on libabigail
Summary: rpminspect-data-fedora is missing a dependency on libabigail
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpminspect-data-fedora
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-12 12:38 UTC by Petr Pisar
Modified: 2021-03-12 20:50 UTC (History)
2 users (show)

Fixed In Version: rpminspect-data-fedora-1.1-2 rpminspect-data-fedora-1.1-2.fc31 rpminspect-data-fedora-1.1-2.fc32 rpminspect-data-fedora-1.1-2.fc33 rpminspect-data-fedora-1.3-1.el7
Clone Of:
Environment:
Last Closed: 2020-10-12 13:52:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2020-10-12 12:38:40 UTC
rpminspect-data-fedora-1.1-1.fc34.noarch has enabled abidiff inpsection, but it does not run-require libabigail and the test fails, if libabigail package is not installed:

$ rpminspect-fedora sombok-2.4.0-11.fc32.x86_64.rpm sombok-2.4.0-12.fc33.x86_64.rpm | grep -C 10 'command not found'
abidiff:
--------
1) Comparing old vs. new version of /usr/lib64/libsombok.so.3.1.7 in package sombok on x86_64 revealed ABI differences.

Result: BAD
Waiver Authorization: Anyone

Details:
Command: abidiff /before/sombok-2.4.0-11.fc32.x86_64//usr/lib64/libsombok.so.3.1.7 /after/sombok-2.4.0-12.fc33.x86_64//usr/lib64/libsombok.so.3.1.7

sh: abidiff: command not found

Suggested Remedy:
ABI changes introduced during maintenance updates can lead to problems for users.  See the abidiff(1) documentation and the distribution ABI policies to determine if this detected change is allowed.

kmidiff:
--------
Result: OK
Waiver Authorization: Not Waivable

Comment 2 David Cantrell 2020-10-12 13:40:23 UTC
The rpminspect package has a soft dependency on /usr/bin/abidiff using Suggests, but I guess it makes sense for the data package to carry a requires on libabigail since it is configuring the program to enable that inspection.

Comment 3 David Cantrell 2020-10-12 13:52:25 UTC
Fixed.  I will updates coming soon for the stable Fedora releases.  Building in rawhide now.

Comment 4 Fedora Update System 2020-10-12 18:21:16 UTC
FEDORA-2020-a94bb07a4f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a94bb07a4f

Comment 5 Fedora Update System 2020-10-12 18:21:30 UTC
FEDORA-2020-033b741168 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-033b741168

Comment 6 Fedora Update System 2020-10-12 18:21:41 UTC
FEDORA-2020-d5b58c98b1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d5b58c98b1

Comment 7 Fedora Update System 2020-10-12 18:22:06 UTC
FEDORA-EPEL-2020-8a30e5377f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8a30e5377f

Comment 8 Fedora Update System 2020-10-12 19:08:43 UTC
FEDORA-EPEL-2020-8c0c685370 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8c0c685370

Comment 9 Fedora Update System 2020-10-12 22:46:25 UTC
FEDORA-2020-d5b58c98b1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-d5b58c98b1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d5b58c98b1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-10-13 20:18:41 UTC
FEDORA-2020-033b741168 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-033b741168`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-033b741168

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-10-13 20:51:55 UTC
FEDORA-EPEL-2020-8a30e5377f has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8a30e5377f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-10-13 21:02:05 UTC
FEDORA-EPEL-2020-8c0c685370 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8c0c685370

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2020-10-13 21:11:58 UTC
FEDORA-2020-a94bb07a4f has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-a94bb07a4f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a94bb07a4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2020-10-21 19:58:22 UTC
FEDORA-2020-a94bb07a4f has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2020-10-21 19:58:38 UTC
FEDORA-2020-033b741168 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2020-10-23 22:12:50 UTC
FEDORA-2020-d5b58c98b1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2020-10-27 01:56:09 UTC
FEDORA-EPEL-2020-29de770d20 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-29de770d20

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2020-10-27 02:36:05 UTC
FEDORA-EPEL-2020-1e1f8c28d4 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1e1f8c28d4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Vít Ondruch 2020-10-29 15:42:54 UTC
Unfortunately, adding hard dependencies on everything make rpminspect unwelcome on my system. I don't want to install various shells and what not. If they were at least weak dependencies ...

Comment 20 David Cantrell 2020-10-30 13:41:14 UTC
So originally I had those requirements as 'Suggests' on the rpminspect package itself.  To me it made more sense to move them over the data package since that would be providing the rules about what tests were enabled or not.  So that's what I did.

I do think they should be specified as a weak dependency.  I chose Suggests, but that led to many people not getting those additional packages installed.  Should they be listed as Recommends instead?

I would like to fix this up to make it more flexible for users while also indicating what packages you do need to have in case you want to run all of the inspections.

Comment 21 Vít Ondruch 2020-10-30 14:42:50 UTC
(In reply to David Cantrell from comment #20)
> So originally I had those requirements as 'Suggests' on the rpminspect
> package itself.  To me it made more sense to move them over the data package
> since that would be providing the rules about what tests were enabled or
> not.  So that's what I did.
> 
> I do think they should be specified as a weak dependency.  I chose Suggests,
> but that led to many people not getting those additional packages installed.
> Should they be listed as Recommends instead?
> 
> I would like to fix this up to make it more flexible for users while also
> indicating what packages you do need to have in case you want to run all of
> the inspections.

Ah, thx for explanation. The Suggests are not installed at all, but Recommends are installed by default, but can be disabled. Therefore Recommends would be ideal from my POV

Comment 22 Fedora Update System 2020-11-11 02:37:15 UTC
FEDORA-EPEL-2020-29de770d20 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2021-02-26 01:50:10 UTC
FEDORA-EPEL-2021-687ea4dc24 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-687ea4dc24

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2021-03-12 20:50:36 UTC
FEDORA-EPEL-2021-687ea4dc24 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.