RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1887775 - live update interface fail as the live interface type changed
Summary: live update interface fail as the live interface type changed
Keywords:
Status: CLOSED DUPLICATE of bug 1949432
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libvirt
Version: 9.1
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: ---
Assignee: Laine Stump
QA Contact: Yanqiu Zhang
URL:
Whiteboard:
Depends On:
Blocks: 1949432
TreeView+ depends on / blocked
 
Reported: 2020-10-13 10:26 UTC by yalzhang@redhat.com
Modified: 2022-09-20 17:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1949432 (view as bug list)
Environment:
Last Closed: 2022-09-20 13:28:03 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)

Description yalzhang@redhat.com 2020-10-13 10:26:29 UTC 
Description of problem:
update interface with <interface type='network'> will fail as the live interface type changed to direct/bridge. The patch
https://www.spinics.net/linux/fedora/libvir/msg203162.html fix the bridge type, but for the direct type and bridge type interface connected to ovs bridge, the issue still exists.

Version-Release number of selected component (if applicable):
libvirt-6.6.0-6.virtcov.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare a macvtap network like:
# virsh net-dumpxml direct-bridge
<network>
  <name>direct-bridge</name>
  <uuid>ab3c21e0-2282-47e0-8211-e8df2118664f</uuid>
  <forward dev='eno1' mode='bridge'>
    <interface dev='eno1'/>
    <interface dev='eno2'/>
  </forward>
</network>

and prepare interface xml as:
# cat interface.xml
<interface type='network'>
<source network='direct-bridge'/>
<mac address='52:54:00:59:cb:11'/>
<model type='virtio'/>
</interface>

 start the vm.

2. hotplug the interface device, then check the live xml, the interface type changed from <interface type='network'>  to <interface type='direct'>
# virsh attach-device rhel interface.xml
# virsh dumpxml rhel | grep /interface -B12
<interface type='direct'>
      <mac address='52:54:00:59:cb:11'/>
      <source network='direct-bridge' portid='a2dac94a-37b2-4fed-a166-b7ffc9931868' dev='eno1' mode='bridge'/>
      <target dev='macvtap0'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x04' slot='0x00' function='0x0'/>
    </interface>

3. use the xml with interface type='network' to do the update-device, it failed
# cat interface.xml
<interface type='network'>
<source network='direct-bridge'/>
<model type='virtio'/>
<link state='down'/>
  <mac address='52:54:00:59:cb:11'/>
</interface>
# virsh update-device rhel interface.xml
error: Failed to update device from interface.xml
error: Operation not supported: unable to change config on 'network' network type

Actual results:
in step 3, the live update failed

Expected results:
the live update should pass

Additional info:
This is the similar scenario with https://www.spinics.net/linux/fedora/libvir/msg203162.html

For ovs bridge, the live update will also fail.
Comment 1 Laine Stump 2020-10-14 01:48:32 UTC 
It appears that we're comparing the "ActualType" (direct in this case) to the config type of the modified interface ("network" in this case) rather than to the actual type that resolves to. This sounds eerily similar to:

commit bc85c34ea91c46588423fa24e56e09ca5aab31dd
Author: Laine Stump <laine>
Date:   Thu May 28 18:04:24 2020 -0400

    qemu: don't reject interface update when switching to/from bridged network
    

which went into upstream before 6.5.0, so should be in the build referenced here (6.6.0). I would guess that either I missed some case, or caused a regression. I can look at it next week.
Comment 2 John Ferlan 2021-09-09 18:32:27 UTC 
Bulk update: Move RHEL-AV bugs to RHEL8 with existing RHEL9 clone.
Comment 4 Yanqiu Zhang 2022-04-06 02:51:05 UTC 
Issue still exists on latest rhel8:
libvirt-8.0.0-5.module+el8.6.0+14480+c0a3aa0f.x86_64
qemu-kvm-6.2.0-10.module+el8.6.0+14540+5dcf03db.x86_64


# virsh update-device avocado-vt-vm1 interface-update.xml 
error: Failed to update device from interface-update.xml
error: Operation not supported: unable to change config on 'network' network type

Hi Laine,
Do we have any plan to fix it please? 
Since the 'Stale Date' is going to be expire, we may need to extend it.
Thanks.
Comment 5 Laine Stump 2022-04-06 03:09:33 UTC 
I just extended the stale date by 3 months (is that the only field that needs to be changed?). Thanks for keeping track of it, I tend to forget. :-/
Comment 6 Yanqiu Zhang 2022-04-06 08:17:42 UTC 
(In reply to Laine Stump from comment #5)
> I just extended the stale date by 3 months (is that the only field that

We think so. Thanks.

> needs to be changed?). Thanks for keeping track of it, I tend to forget. :-/
Comment 7 RHEL Program Management 2022-07-13 07:28:26 UTC 
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.
Comment 9 Jaroslav Suchanek 2022-09-20 13:28:03 UTC 

*** This bug has been marked as a duplicate of bug 1949432 ***
Note You need to log in before you can comment on or make changes to this bug.