Bug 1887937 - Review Request: perl-Tie-RefHash - Use references as hash keys
Summary: Review Request: perl-Tie-RefHash - Use references as hash keys
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-13 15:50 UTC by Petr Pisar
Modified: 2020-10-14 15:45 UTC (History)
2 users (show)

Fixed In Version: perl-Tie-RefHash-1.40-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-14 15:45:04 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-10-13 15:50:35 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Tie-RefHash/perl-Tie-RefHash.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Tie-RefHash/perl-Tie-RefHash-1.40-1.fc34.src.rpm
Description:
This module provides the ability to use references as hash keys if you first
"tie" the hash variable to this module. Normally, only the keys of the tied
hash itself are preserved as references; to use references as keys in
hashes-of-hashes, use Tie::RefHash::Nestable, included as part of
Tie::RefHash.

Fedora Account System Username: ppisar


This package delivers a dual-lived Perl module. The same-named binary package will be remove from perl.spec after packaging this one.

Comment 1 Jitka Plesnikova 2020-10-14 10:03:04 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Tie-RefHash-1.40-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Config)
      1 perl(:MODULE_COMPAT_5.32.0) 
      1 perl(overload)
      1 perl(strict)
      1 perl(Tie::Hash)
Binary requires are Ok.

$ rpm -qp --provides perl-Tie-RefHash-1.40-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Tie::RefHash) = 1.40 
      1 perl-Tie-RefHash = 1.40-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Tie-RefHash*
perl-Tie-RefHash.noarch: W: spelling-error %description -l en_US Nestable -> Testable, Ne stable, Ne-stable
perl-Tie-RefHash.src: W: spelling-error %description -l en_US Nestable -> Testable, Ne stable, Ne-stable
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-10-14 13:25:59 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Tie-RefHash

Comment 4 Petr Pisar 2020-10-14 13:52:13 UTC
Thank you for the review and the repository.
I will close this report after removing this package from perl.spec.

Comment 5 Petr Pisar 2020-10-14 15:45:04 UTC
Removed in perl-5.32.0-465.fc34.


Note You need to log in before you can comment on or make changes to this bug.