Bug 1888115

add Keyword: Regression because RHEL-8.4.0-20201012.n.0  works fine!

Created attachment 1721407 [details]
my kickstart file

Hello,

The kickstart file works correctly on my side. Seems that Anaconda can't handle your current storage configuration correctly. 

```
Saving storage configuration...
Failed to save storage configuration
'hel is not a valid name for this device
```

Could you please provide us logs from the installation environment. You can find that in /tmp/*.log.

(In reply to Jiri Konecny from comment #4)
> Hello,
> 
> The kickstart file works correctly on my side. Seems that Anaconda can't
> handle your current storage configuration correctly. 
> 
> ```
> Saving storage configuration...
> Failed to save storage configuration
> 'hel is not a valid name for this device
> ```
> 
> Could you please provide us logs from the installation environment. You can
> find that in /tmp/*.log.

Hi Jiri
I copyed those log files here:
  ftp://fstest.usersys.redhat.com/pub/

Additional info:
  my host OS is Fedora-34
  and I just tried install RHEL-8.4.0-20201012.d.1 on another host(with RHEL-7.3), it works fine.

  might it be a libvirt/kvm bug?

ftp://fstest.usersys.redhat.com/pub/storage.log

search ERROR:

'''
DEBUG:blivet:device req0 new parted_partition parted.Partition instance --
  disk: <parted.disk.Disk object at 0x7f18765c5a20>  fileSystem: None
  number: 2  path: /dev/vda2  type: 0
  name: None  active: True  busy: False
  geometry: <parted.geometry.Geometry object at 0x7f1877345358>  PedPartition: <_ped.Partition object at 0x7f1875ce4f68>
DEBUG:blivet:               PartitionDevice._set_disk: vda2 ; old: None ; new: vda ;
DEBUG:blivet:                    DiskDevice.add_child: name: vda ; child: vda2 ; kids: 1 ;
DEBUG:blivet:               PartitionDevice._set_parted_partition: vda2 ;
DEBUG:blivet:device vda2 new parted_partition parted.Partition instance --
  disk: <parted.disk.Disk object at 0x7f18765c5a20>  fileSystem: None
  number: 2  path: /dev/vda2  type: 0
  name: None  active: True  busy: False
  geometry: <parted.geometry.Geometry object at 0x7f1875cf7390>  PedPartition: <_ped.Partition object at 0x7f1875c7c0f8>
DEBUG:blivet:fixing size of non-existent 1024 MiB partition vda1 (107) with non-existent xfs filesystem mounted at /boot
DEBUG:blivet:fixing size of non-existent 26 GiB partition vda2 (100) with non-existent lvmpv
DEBUG:blivet:get_format('None') returning DeviceFormat instance with object id 114
ERROR:anaconda.modules.storage.partitioning.base_partitioning:Storage configuration has failed: 'hel is not a valid name for this device
INFO:anaconda.threading:Thread Failed: AnaTaskThread-AutomaticPartitioningTask-1 (139743050430208)
ERROR:anaconda.modules.common.task.task:Thread AnaTaskThread-AutomaticPartitioningTask-1 has failed: Traceback (most recent call last):
  File "/usr/lib64/python3.6/site-packages/pyanaconda/modules/storage/partitioning/base_partitioning.py", line 52, in run
    self._run(self._storage)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/modules/storage/partitioning/automatic/noninteractive_partitioning.py", line 42, in _run
    self._configure_partitioning(storage)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/modules/storage/partitioning/automatic/automatic_partitioning.py", line 208, in _configure_partitioning
    self._do_autopart(storage, scheme, requests, encrypted, luks_format_args)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/modules/storage/partitioning/automatic/automatic_partitioning.py", line 296, in _do_autopart
    schedule_volumes(storage, devs, scheme, requests, encrypted)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/modules/storage/partitioning/automatic/utils.py", line 399, in schedule_volumes
    container = new_container(parents=pvs)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/blivet.py", line 561, in new_vg
    return LVMVolumeGroupDevice(name, pvs, *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/devices/lvm.py", line 144, in __init__
    exists=exists, sysfs_path=sysfs_path)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/devices/container.py", line 66, in __init__
    super(ContainerDevice, self).__init__(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/blivet/devices/storage.py", line 141, in __init__
    raise ValueError("%s is not a valid name for this device" % name)
ValueError: 'hel is not a valid name for this device
'''

Based on the traceback above, I'm switching the component to our storage library.

Could you please look on why this is happening?

There are two problems:
1. Anaconda tells blivet the product name is "'hel", because the product name is in quotes -- "'Red Hat Enterprise Linux'". I'm not sure if this is a problem with the image or if Anaconda should remove the quotes, but product name "'hel" is not correct so I'm moving this back to Anaconda. the 
2. Blivet uses the product name for VG name and "'hel" is not a valid name for a VG. We shouldn't blindly use product name without checking it so I'll clone this for blivet and we'll validate the product name before using it.

JianHong Yin, can you please confirm the problem is still reproducible with RHEL-8.5 or RHEL-8.6?
Thank you