Bug 1888167 - Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's "Scalablilty Protocols"
Summary: Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1888117
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-14 09:36 UTC by Fabian Affolter
Modified: 2020-12-30 01:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-12-30 01:37:14 UTC
Type: Bug
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-10-14 09:36:00 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-nanomsg-mangos-3.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-nanomsg-mangos-3-3.1.3-1.fc33.src.rpm

Project URL: https://github.com/nanomsg/mangos

Description:
Mangos is a pure Golang implementation of nanomsg's "Scalablilty Protocols".

Koji scratch build:
fails due to missing dependency

rpmlint output:
$ rpmlint golang-nanomsg-mangos-3-3.1.3-1.fc33.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint golang-nanomsg-mangos-3-devel-3.1.3-1.fc33.noarch.rpm 
golang-nanomsg-mangos-3-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/go.nanomsg.org/mangos/v3/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-11-06 07:28:58 UTC
%build
for cmd in macat/macat perf; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

perf binary is using a name too generic that might conflict with other packages, please rename it to a more specific name.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Fabian Affolter 2020-12-11 22:11:03 UTC
Thanks for the review.

Comment 3 Gwyn Ciesla 2020-12-11 22:17:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-nanomsg-mangos-3

Comment 4 Fedora Update System 2020-12-21 08:31:07 UTC
FEDORA-2020-d47e59b0c5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d47e59b0c5

Comment 5 Fedora Update System 2020-12-22 02:18:01 UTC
FEDORA-2020-d47e59b0c5 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d47e59b0c5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d47e59b0c5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-12-30 01:37:14 UTC
FEDORA-2020-d47e59b0c5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.