Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1888552

Summary:	Backport a patch into ansible-runner 1.3.4-2.el8ar.noarch
Product:	Red Hat OpenStack	Reporter:	Cédric Jeanneret <cjeanner>
Component:	python-ansible-runner	Assignee:	mathieu bultel <mbultel>
Status:	CLOSED ERRATA	QA Contact:	nlevinki <nlevinki>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	16.1 (Train)	CC:	aschultz, dhill, gchamoul, jjoyce, mbultel, shrjoshi
Target Milestone:	z3	Keywords:	Triaged
Target Release:	16.1 (Train on RHEL 8.2)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-ansible-runner-1.4.0-1.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-15 18:37:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1887754

Description Cédric Jeanneret 2020-10-15 07:51:55 UTC

Description of problem:
With the shipped version of ansible-runner in osp-16.1 (on rhel-8.2), we have warning about unclosed resources, such as:

/usr/lib/python3.6/site-packages/validations_libs/ansible.py:374: ResourceWarning: unclosed file <_io.BufferedWriter name='/var/log/validations/artifacts/6795770e-908a-430e-91dc-b77324e1ec16_check-ram.yaml_2020-10-15T07:22:31.146719Z/artif
acts/stdout'>


While this isn't an actual issue with the application using ansible-runner, it might mislead the operator into believing there's an issue with this unclosed resource.

Importing the following patch (a 2-liners, really) into 1.3.4 would prevent this ugly output:
https://github.com/ansible/ansible-runner/commit/71ebaa7afc9d786374025564c6b4fbda8832824a

I've tested it on my local env, and it indeed solves the issue.


Version-Release number of selected component (if applicable):
ansible-runner-1.3.4-2.el8ar.noarch
python3-ansible-runner-1.3.4-2.el8ar.noarch

How reproducible:
Always

Steps to Reproduce:
1. Run `openstack tripleo validator run --validation <some validation>'
2. Check the run output
3.

Actual results:
We see warning about that unclosed artifact

Expected results:
We shouldn't get that unclosed artifact warning


Additional info:
Patch should apply cleanly.

Comment 1 mathieu bultel 2020-10-20 07:51:11 UTC

The upstream requirements for ansible-runner in stable/train is updated now from 1.3.4 to 1.4.0.
I'm moving this BZ to Reldel according to irc discuss, Reldel should be able to bump the ansible-runner version downstream:
09:32 < matbu> is there a requirements repo like upstream ?
09:34 < shreshtha> we can update that. update the bug with version detail/upstream rpm if available and we will take it from here

Comment 3 mathieu bultel 2020-10-20 11:40:31 UTC

Hey,

Not sure if it's the right place but it's here:
https://releases.ansible.com/ansible-runner/rpm/epel-7-x86_64/ansible-runner-1.4.0-1.el7.noarch.rpm

Comment 4 mathieu bultel 2020-11-02 14:51:09 UTC

Is ok for you now ?

Comment 5 Cédric Jeanneret 2020-11-03 07:22:14 UTC

*** Bug 1887754 has been marked as a duplicate of this bug. ***

Comment 18 errata-xmlrpc 2020-12-15 18:37:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.3 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:5413