Bug 1888965 - Review Request: golang-github-muesli-reflow - Word-wrap strings or entire blocks of text
Summary: Review Request: golang-github-muesli-reflow - Word-wrap strings or entire blo...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 33
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2020-10-16 16:04 UTC by Joe Doss
Modified: 2020-11-06 14:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-11-06 14:20:02 UTC
Type: Bug
mail: fedora-review+

Attachments (Terms of Use)

Description Joe Doss 2020-10-16 16:04:20 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708571-golang-github-muesli-reflow/golang-github-muesli-reflow.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708571-golang-github-muesli-reflow/golang-github-muesli-reflow-0.1.0-1.fc33.src.rpm

Description: Reflow lets you word-wrap strings or entire blocks of text. It follows the io.Writer interface and supports ANSI escape sequences.

Fedora Account System Username: jdoss

Comment 1 Fabian Affolter 2020-10-16 20:31:50 UTC

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "Expat
     License". 16 files have unknown license. Detailed output of
     licensecheck in /home/fab/Documents/repos/reviews/1888965-golang-
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     golang-github-hsiafan-glow-devel, golang-github-francoispqt-gojay-
     streadway-amqp-devel, golang-github-boltdb-bolt-devel, golang-github-
     miekg-mmark-devel, golang-github-tinylib-msgp-devel, golang-github-
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: golang-github-muesli-reflow-devel-0.1.0-1.fc34.noarch.rpm
golang-github-muesli-reflow-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/muesli/reflow/.goipath
golang-github-muesli-reflow.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
golang-github-muesli-reflow-devel.noarch: W: invalid-url URL: https://github.com/muesli/reflow <urlopen error [Errno -3] Temporary failure in name resolution>
golang-github-muesli-reflow-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/muesli/reflow/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums
https://github.com/muesli/reflow/archive/v0.1.0/reflow-0.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : f558a7918af1727e5153fa20b4b03f619a4855485ab41e98b89e5474571afaed
  CHECKSUM(SHA256) upstream package : f558a7918af1727e5153fa20b4b03f619a4855485ab41e98b89e5474571afaed

golang-github-muesli-reflow-devel (rpmlib, GLIBC filtered):


Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1888965
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: SugarActivity, Java, R, Haskell, Python, fonts, PHP, Ocaml, C/C++, Perl

Comment 2 Gwyn Ciesla 2020-10-27 16:43:43 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-muesli-reflow

Note You need to log in before you can comment on or make changes to this bug.