Document URL: https://docs.openshift.com/container-platform/4.6/installing/installing_gcp/installing-gcp-customizations.html Section Number and Name: Installation configuration parameters Describe the issue: To support changing disk type and disk size on GCP, 2 parameters diskType and diskSizeGB are introduced. They are missing in 4.6 document. Please refer to https://issues.redhat.com/browse/CORS-1275 https://bugzilla.redhat.com/show_bug.cgi?id=1836339 Suggestions for improvement: Suggest to add a description for diskType and diskSizeGB Additional information:
@yanyang I see that the examples on this page don't make use of the diskType and diskSizeGB parameters. If they're being introduced in the table, should the corresponding example in that section include a use case with them? I'm assuming the descriptions can be taken from here: https://github.com/openshift/installer/blob/master/docs/user/gcp/customization.md#machine-pools but please let me know.
Preview link: https://deploy-preview-37122--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-customizations.html#installation-configuration-parameters-additional-gcp_installing-gcp-customizations Link to PR: https://github.com/openshift/openshift-docs/pull/37122
Marking as verified based on PR feedback: https://github.com/openshift/openshift-docs/pull/37122
@tsze could you confirm if this change would be applicable to versions other than 4.6?
> should the corresponding example in that section include a use case with them? Yes. It would be better to add it in the example. It seems that you have got it added in the Sample customized install-config.yaml file. > could you confirm if this change would be applicable to versions other than 4.6? It's introduced in 4.6. So it's applicable to 4.6, 4.7, 4.8, 4.9.
@yanyang here is a second PR, just for the 4.6 YAML file https://github.com/openshift/openshift-docs/pull/37405 Could you please confirm if this looks good to go, or if something else should be added?
Both PRs have been merged: https://github.com/openshift/openshift-docs/pull/37268 https://github.com/openshift/openshift-docs/pull/37405
@tsze, @jiwei, I have opened a new PR to update GCP configs in 4.6+ with the new recommendation of diskSizeGB: 1024, could you PTAL? PR: https://github.com/openshift/openshift-docs/pull/37836 Preview link: https://deploy-preview-37836--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-customizations.html#installation-gcp-config-yaml_installing-gcp-customizations
PR LGTM.
PR merged
updated docs: https://docs.openshift.com/container-platform/4.6/installing/installing_gcp/installing-gcp-customizations.html#installation-configuration-parameters-additional-gcp_installing-gcp-customizations closing ticket