Bug 1889247 - Installing a cluster on GCP with customizations page missing parameters diskType and diskSizeGB
Summary: Installing a cluster on GCP with customizations page missing parameters diskT...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Documentation
Version: 4.6
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.6.0
Assignee: Jesse Dohmann
QA Contact: Jianli Wei
Latha S
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-19 07:13 UTC by Yang Yang
Modified: 2021-12-07 20:17 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-07 20:17:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Yang Yang 2020-10-19 07:13:00 UTC
Document URL: 
https://docs.openshift.com/container-platform/4.6/installing/installing_gcp/installing-gcp-customizations.html

Section Number and Name: 
Installation configuration parameters

Describe the issue: 
To support changing disk type and disk size on GCP, 2 parameters diskType and diskSizeGB are introduced. They are missing in 4.6 document.

Please refer to
https://issues.redhat.com/browse/CORS-1275
https://bugzilla.redhat.com/show_bug.cgi?id=1836339

Suggestions for improvement: 
Suggest to add a description for diskType and diskSizeGB

Additional information:

Comment 2 Jesse Dohmann 2021-10-04 22:53:36 UTC
@yanyang I see that the examples on this page don't make use of the diskType and diskSizeGB parameters. If they're being introduced in the table, should the corresponding example in that section include a use case with them? 

I'm assuming the descriptions can be taken from here: https://github.com/openshift/installer/blob/master/docs/user/gcp/customization.md#machine-pools but please let me know.

Comment 4 Jesse Dohmann 2021-10-06 19:52:39 UTC
Marking as verified based on PR feedback: https://github.com/openshift/openshift-docs/pull/37122

Comment 5 Jesse Dohmann 2021-10-06 20:47:42 UTC
@tsze could you confirm if this change would be applicable to versions other than 4.6?

Comment 6 Yang Yang 2021-10-08 09:21:17 UTC
> should the corresponding example in that section include a use case with them? 

Yes. It would be better to add it in the example. It seems that you have got it added in the Sample customized install-config.yaml file.

> could you confirm if this change would be applicable to versions other than 4.6?

It's introduced in 4.6. So it's applicable to 4.6, 4.7, 4.8, 4.9.

Comment 7 Jesse Dohmann 2021-10-12 19:42:51 UTC
@yanyang here is a second PR, just for the 4.6 YAML file https://github.com/openshift/openshift-docs/pull/37405

Could you please confirm if this looks good to go, or if something else should be added?

Comment 11 Jesse Dohmann 2021-10-20 20:59:14 UTC
@tsze,  @jiwei, I have opened a new PR to update GCP configs in 4.6+ with the new recommendation of diskSizeGB: 1024, could you PTAL? 

PR: https://github.com/openshift/openshift-docs/pull/37836

Preview link: https://deploy-preview-37836--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-customizations.html#installation-gcp-config-yaml_installing-gcp-customizations

Comment 12 To Hung Sze 2021-10-21 22:23:36 UTC
PR LGTM.

Comment 13 Jesse Dohmann 2021-10-25 17:13:57 UTC
PR merged


Note You need to log in before you can comment on or make changes to this bug.