In order to make sure chaos scenarios won't affect user workload we need to enable machine health check by default on freshly installed clusters.
Not sure what it means, are you talking about https://github.com/openshift/assisted-service/blob/master/deploy/assisted-service.yaml#L29 ?
Michael I am talking about https://docs.openshift.com/container-platform/4.5/machine_management/deploying-machine-health-checks.html
@firstname.lastname@example.org I guess we can do it the same way we create the BMH?
email@example.com, firstname.lastname@example.org if we want to add it we should probably do it during the ignition generation.
I think that the problem here is more profound: since the assisted installer is not an IPI, it does not integrate at all with the MachineHealthCheck (MHC). I think this bz should be changed to a request for extension: let assisted-installed cluster integrate with MHC, so that non-responsive nodes can be automatically recycled/restarted.
(In reply to Eran Cohen from comment #3)
> @email@example.com I guess we can do it the same way we create the BMH?
> firstname.lastname@example.org, email@example.com if we want to add it we should probably do
> it during the ignition generation.
In terms of implementation, if the purpose is to add a custom manifest to the cluster, such as the one describe here:
It can be achieved by using the manifest API to provide it after the cluster was created and it will be rendered into the ign file by:
@firstname.lastname@example.org why are we integrated with Machine Health from the start? I mean, why should we create any specific manifest? Does not openshift-installer should do it? by some kind of configuraiton
Please take a look at BZ #1889651 comments to have more context about this change.