Bug 1889333 - [CNV][Chaos] Integrate with MachineHealthCheck
Summary: [CNV][Chaos] Integrate with MachineHealthCheck
Keywords:
Status: NEW
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: assisted-installer
Version: 4.6
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: ---
Assignee: Angus Salkeld
QA Contact: Yuri Obshansky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-19 12:23 UTC by Piotr Kliczewski
Modified: 2020-11-26 08:54 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)

Description Piotr Kliczewski 2020-10-19 12:23:18 UTC
In order to make sure chaos scenarios won't affect user workload we need to enable machine health check by default on freshly installed clusters.

Comment 1 Michael Filanov 2020-10-20 06:48:20 UTC
Not sure what it means, are you talking about https://github.com/openshift/assisted-service/blob/master/deploy/assisted-service.yaml#L29 ?

Comment 3 Eran Cohen 2020-10-20 08:00:36 UTC
@yshnaidm@redhat.com  I guess we can do it the same way we create the BMH?
alazar@redhat.com, rom@redhat.com if we want to add it we should probably do it during the ignition generation.
Thoughts?

Comment 4 Dan Kenigsberg 2020-10-20 10:07:26 UTC
I think that the problem here is more profound: since the assisted installer is not an IPI, it does not integrate at all with the MachineHealthCheck (MHC). I think this bz should be changed to a request for extension: let assisted-installed cluster integrate with MHC, so that non-responsive nodes can be automatically recycled/restarted.

Comment 5 Moti Asayag 2020-11-25 19:16:40 UTC
(In reply to Eran Cohen from comment #3)
> @yshnaidm@redhat.com  I guess we can do it the same way we create the BMH?
> alazar@redhat.com, rom@redhat.com if we want to add it we should probably do
> it during the ignition generation.
> Thoughts?

In terms of implementation, if the purpose is to add a custom manifest to the cluster, such as the one describe here:
https://docs.openshift.com/container-platform/4.5/machine_management/deploying-machine-health-checks.html#machine-health-checks-resource_deploying-machine-health-checks

It can be achieved by using the manifest API to provide it after the cluster was created and it will be rendered into the ign file by: 
https://github.com/openshift/assisted-service/blob/master/internal/ignition/ignition.go#L141

Comment 6 yevgeny shnaidman 2020-11-26 06:33:12 UTC
@ercohen@redhat.com why are we integrated with Machine Health from the start? I mean, why should we create any specific manifest? Does not openshift-installer should do it? by some kind of configuraiton

Comment 7 Piotr Kliczewski 2020-11-26 08:39:24 UTC
Please take a look at BZ #1889651 comments to have more context about this change.


Note You need to log in before you can comment on or make changes to this bug.