Bug 1889891 - Backport timecache LRU fix
Summary: Backport timecache LRU fix
Keywords:
Status: VERIFIED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 4.6.z
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.7.0
Assignee: Ryan Phillips
QA Contact: Sunil Choudhary
URL:
Whiteboard:
Depends On:
Blocks: 1889936
TreeView+ depends on / blocked
 
Reported: 2020-10-20 20:25 UTC by Ryan Phillips
Modified: 2020-11-24 16:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Github openshift kubernetes pull 418 None closed Bug 1889891: UPSTREAM: 94774: Fix misusage of RLock in timeCache lru.Cache.Get() 2020-11-24 16:05:39 UTC

Description Ryan Phillips 2020-10-20 20:25:52 UTC
Description of problem:
```
Lru's Get() method also updates the least recent usage information. So, we should not use RLock() and even RWLock here.
An alternative fix is just using github.com/hashicorp/golang-lru, but that will introduce more diffs. If that is the better fix, I can also do that.
```

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:


Note You need to log in before you can comment on or make changes to this bug.