Spec URL: http://shahms.mesd.k12.or.us/packages/bzrtools.spec SRPM URL: http://shahms.mesd.k12.or.us/packages/bzrtools-0.7-1.src.rpm Description: BzrTools is a collection of plugins for Bazaar-NG (bzr). Among the included plugins are: * push - uses rsync to push local changes to a remote server * annotate - prints a file annotated with the revision next to each line * baz-import - (Requres PyBaz) import an arch archive losslessly into bzr * shelve/unshelve - allows you to undo some changes, commit, and restore * clean-tree - remove unknown, ignored-junk, or unversioned files from the tree * graph-ancestry - use dot to produce banch ancestry graphs * shell - a bzr command interpreter with command completion * patch - apply a patch to your tree from a file or URL
Looks like you want to update to 0.8.1, but: - spec file is clean and legible. - md5sum matches - rpmlint: E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644 though since they are library routines, it isn't necessary to be executable. - license matches source. - owns all files and directories. MUST FIX: - add COPYING to %doc.
Thanks for taking the time to review the package. I added COPYING, updated to 0.8.1 and fixed a minor problem with bzrtools requiring the same version of bzr rather than the actually required version of 0.8 The new files are at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-1.src.rpm
(In reply to comment #1) > - rpmlint: > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644 Oops, these need to get fixed. Those scripts that can be run directly need to be executable. Those that are library modules need to have #!/usr/bin/python stripped from them. More on Monday...
Fixed, new files at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-2.src.rpm
- Package builds in mock - rpmlint clean now Fix: - BR should be python, not python-devel. With that fix, this is approved.
packages with BR: python are at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-3.src.rpm
APPROVED.
Package Change Request ====================== Package Name: bzrtools New Branches: epel7 Owners: bar stevetraylen
Git done (by process-git-requests). Dropped bar from the owners list.