Red Hat Bugzilla – Bug 189040
Review Request: perl-Object-Accessor
Last modified: 2007-11-30 17:11:30 EST
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Object-Accessor/perl-Object-Accessor.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Object-Accessor-0.12-1.src.rpm
Object::Accessor provides an interface to create per object accessors (as
opposed to per Class accessors, as, for example, Class::Accessor provides).
Requires: perl(Params::Check) >= 0.23 is redundant; RPM finds the requirement on
its own, leading to a duplicate in the requires list. I believe we all decided
that this was a blocker.
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible. It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
X final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
RPM doesn't pick up the versioned dep. While I'd prefer to keep the explicit
versioned dep, here it is without:
For some reason I recall that it was decided that we shouldn't allow the
duplicate requires, but now I can't find a reference. I seem to remember that
you were in on the discussion, but if you don't remember then my mind must be
playing tricks on me. I personally don't have any problem with it since RPM
won't determine versioned perl dependencies on its own, so I'll go ahead and
approve this. I do think it's worth clarifying.
APPROVED. Just check in the version you prefer.
Imported (-2), branches created, and builds requested.