Bug 1890668 - [4.5.z] s390x: Generate new ostree rpm with fix for rootfs immutability
Summary: [4.5.z] s390x: Generate new ostree rpm with fix for rootfs immutability
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: RHCOS
Version: 4.5
Hardware: s390x
OS: Linux
high
medium
Target Milestone: ---
: 4.5.z
Assignee: Colin Walters
QA Contact: Michael Nguyen
URL:
Whiteboard:
Depends On: 1890361 1890667
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-22 16:57 UTC by Micah Abbott
Modified: 2020-10-30 20:32 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1890667
Environment:
Last Closed: 2020-10-27 20:42:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Micah Abbott 2020-10-22 16:57:17 UTC
+++ This bug was initially created as a clone of Bug #1890667 +++

+++ This bug was initially created as a clone of Bug #1890361 +++

Recently the s390x 4.5 RHCOS pipeline started failing because the ostree version of fedora32 which is used in the cosa container had the fix for 

https://bugzilla.redhat.com/show_bug.cgi?id=1867601

Because of this - the root file system is immutable - which is good, but the ostree version in RHCOS 4.5 is an older version which does not have the fix for the above BZ. This causes rollbacks and upgrades to fail.

For now, the coreos-assembler is patched to remove the immutable bit, but it would be good if ostree is bumped with the fix for RHCOS 4.5.

--- Additional comment from Prashanth Sundararaman on 2020-10-22 01:30:18 UTC ---

This is the said fix that would need to be backported:

https://github.com/ostreedev/ostree/pull/2179

--- Additional comment from Micah Abbott on 2020-10-22 16:54:49 UTC ---

Targeting 4.7 (though the fix should already be present there and in 4.6); we will probably need to clone this for 4.5.z

Comment 1 Micah Abbott 2020-10-25 18:38:28 UTC
Higher priority items prevented work from happening on this issue; labeling UpcomingSprint

Comment 2 Colin Walters 2020-10-26 21:59:22 UTC
Do we really need to fix this in 4.5.z?

Did we ship 4.5.x s390x bootimages with the immutable bit on or not?

I think the way it should work is:

- bootimage is 4.5.x, immutable bit is not set
- upgrade to 4.6.1 happens using *old* ostree, new deployment still doesn't have immutable bit
- reboot
- later upgrade to 4.6.2 happens using new ostree, new deployment has immutable bit
- old 4.5.x deployment without immutable bit is GC'd
- From now on the immutable bit is set correctly

Am I missing something?

Comment 3 Prashanth Sundararaman 2020-10-27 20:39:54 UTC
The bootimage for s390x today does not have the immutable bit set. I guess we don't really need the fix in 4.5.Z. A 4.6.1 -> 4.6.2 upgrade should have this set as outlined above.

Comment 4 Colin Walters 2020-10-27 20:42:41 UTC
OK closing, but if we have reason to believe differently in the future we can reopen.


Note You need to log in before you can comment on or make changes to this bug.