1890673 – NFD is missing a build flag to build correctly

Bug 1890673 - NFD is missing a build flag to build correctly

Summary: NFD is missing a build flag to build correctly

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Node Feature Discovery Operator
Sub Component:
Version:	4.6
Hardware:	Unspecified
OS:	Unspecified
Priority:	urgent
Severity:	urgent
Target Milestone:	---
Target Release:	4.6.z
Assignee:	Carlos Eduardo Arango Gutierrez
QA Contact:	Walid A.
Docs Contact:
URL:
Whiteboard:
Depends On:	1890672
Blocks:
TreeView+	depends on / blocked

Reported:	2020-10-22 17:08 UTC by Zvonko Kosic
Modified:	2020-11-09 14:09 UTC (History)
CC List:	5 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2020-11-09 14:09:33 UTC
Target Upstream Version:

Attachments	(Terms of Use)

Links
System	ID	Priority	Status	Summary	Last Updated
Github	openshift node-feature-discovery pull 21	None	closed	[release-4.6] Bug 1890673: Fix pathPrefix in source/config.go	2021-02-15 16:23:35 UTC
Github	openshift node-feature-discovery pull 23	None	closed	[release-4.6] Bug 1890673: fix gobuild ldflag on Makefile	2021-02-15 16:23:35 UTC
Red Hat Product Errata	RHBA-2020:4341	None	None	None	2020-11-09 14:09:43 UTC

Description Zvonko Kosic 2020-10-22 17:08:57 UTC

This bug was initially created as a copy of Bug #1890672

I am copying this bug because: 



Description of problem:
NFD is missing a build flag to build correctly. 
It assumes it is a local build and reads the container info rather then the host info. 

Version-Release number of selected component (if applicable):
4.6 and upwards

How reproducible:
Use a 4.6 cluster

Comment 3 Walid A. 2020-11-04 01:20:46 UTC

Verified the correct labels are on the worker node when deployed NFD operator 4.6.0-202010311441.p0 from Console/OperatorHub on OCP 4.6.0-0.nightly-2020-11-02-081936:

                    feature.node.kubernetes.io/cpu-cpuid.ADX=true
                    feature.node.kubernetes.io/cpu-cpuid.AESNI=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX2=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512BW=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512CD=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512DQ=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512F=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512VL=true
                    feature.node.kubernetes.io/cpu-cpuid.FMA3=true
                    feature.node.kubernetes.io/cpu-cpuid.HLE=true
                    feature.node.kubernetes.io/cpu-cpuid.MPX=true
                    feature.node.kubernetes.io/cpu-cpuid.RTM=true
                    feature.node.kubernetes.io/cpu-hardware_multithreading=true
                    feature.node.kubernetes.io/custom-rdma.available=true
                    feature.node.kubernetes.io/kernel-selinux.enabled=true
                    feature.node.kubernetes.io/kernel-version.full=4.18.0-193.28.1.el8_2.x86_64
                    feature.node.kubernetes.io/kernel-version.major=4
                    feature.node.kubernetes.io/kernel-version.minor=18
                    feature.node.kubernetes.io/kernel-version.revision=0
                    feature.node.kubernetes.io/pci-1d0f.present=true
                    feature.node.kubernetes.io/storage-nonrotationaldisk=true
                    feature.node.kubernetes.io/system-os_release.ID=rhcos
                    feature.node.kubernetes.io/system-os_release.VERSION_ID=4.6
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.major=4
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.minor=6

Will verify on 4.6.2 build when available

Comment 4 Walid A. 2020-11-05 01:10:33 UTC

Also verified on OCP 4.6.0-0.nightly-2020-11-02-081936.  Built local images of:

NFD operator:
 - https://github.com/openshift/cluster-nfd-operator.git
and NFD operand:
 - https://github.com/openshift/node-feature-discovery.git

from their respective github release-4.6 branches.  
Pushed local images pushed to quay.io.
Deployed NFD operator and operand using these images.
Verified labels are correct:

                    feature.node.kubernetes.io/cpu-cpuid.ADX=true
                    feature.node.kubernetes.io/cpu-cpuid.AESNI=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX2=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512BW=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512CD=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512DQ=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512F=true
                    feature.node.kubernetes.io/cpu-cpuid.AVX512VL=true
                    feature.node.kubernetes.io/cpu-cpuid.FMA3=true
                    feature.node.kubernetes.io/cpu-cpuid.HLE=true
                    feature.node.kubernetes.io/cpu-cpuid.MPX=true
                    feature.node.kubernetes.io/cpu-cpuid.RTM=true
                    feature.node.kubernetes.io/cpu-hardware_multithreading=true
                    feature.node.kubernetes.io/custom-rdma.available=true
                    feature.node.kubernetes.io/kernel-selinux.enabled=true
                    feature.node.kubernetes.io/kernel-version.full=4.18.0-193.28.1.el8_2.x86_64
                    feature.node.kubernetes.io/kernel-version.major=4
                    feature.node.kubernetes.io/kernel-version.minor=18
                    feature.node.kubernetes.io/kernel-version.revision=0
                    feature.node.kubernetes.io/pci-1d0f.present=true
                    feature.node.kubernetes.io/storage-nonrotationaldisk=true
                    feature.node.kubernetes.io/system-os_release.ID=rhcos
                    feature.node.kubernetes.io/system-os_release.VERSION_ID=4.6
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.major=4
                    feature.node.kubernetes.io/system-os_release.VERSION_ID.minor=6

Comment 6 errata-xmlrpc 2020-11-09 14:09:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6.3 extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4341

Note You need to log in before you can comment on or make changes to this bug.