Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1890702

Summary: suppress-time-limits breaks pretty-printing variables
Product: Red Hat Enterprise Linux 8 Reporter: Frank Sorenson <fsorenso>
Component: systemtapAssignee: Frank Ch. Eigler <fche>
systemtap sub component: system-version QA Contact: Martin Cermak <mcermak>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: dsmith, lberk, mcermak, mjw
Version: 8.2Keywords: Bugfix, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: systemtap-4.4-1.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:44:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch none

Description Frank Sorenson 2020-10-22 18:19:11 UTC 
Created attachment 1723597 [details]
patch

Description of problem:

When --suppress-time-limits is used, pretty-printing a variable errors out because 'c->actionremaining' does not exist.


Version-Release number of selected component (if applicable):

systemtap-4.3-4.el8.x86_64
(also upstream)


How reproducible:

easy - see reproducer below


Steps to Reproduce:

# stap -g --suppress-time-limits -e 'probe kernel.function("vfs_open") { printf("%s(path: %s)\n", ppfunc(), $path$) ; exit() }'


Actual results:

# stap -g --suppress-time-limits -e 'probe kernel.function("vfs_open") { printf("%s(path: %s)\n", ppfunc(), $path$) ; exit() }'
In file included from ./include/asm-generic/bug.h:5,
                 from ./arch/x86/include/asm/bug.h:83,
                 from ./include/linux/bug.h:5,
                 from ./include/linux/mmdebug.h:5,
                 from ./include/linux/gfp.h:5,
                 from /usr/share/systemtap/runtime/linux/runtime_defines.h:20,
                 from /usr/share/systemtap/runtime/runtime_defines.h:8,
                 from /tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.c:12:
/tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.c: In function ‘function___private__input___dwarf_pretty_print_0’:
/tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.c:545:20: error: ‘struct context’ has no member named ‘actionremaining’
     if (unlikely (c->actionremaining <= 0)) goto out;
                    ^~
./include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’
 # define unlikely(x) __builtin_expect(!!(x), 0)
                                          ^
/tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.c: In function ‘function___private__input___dwarf_pretty_print_1’:
/tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.c:626:20: error: ‘struct context’ has no member named ‘actionremaining’
     if (unlikely (c->actionremaining <= 0)) goto out;
                    ^~
./include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’
 # define unlikely(x) __builtin_expect(!!(x), 0)
                                          ^
make[1]: *** [scripts/Makefile.build:312: /tmp/stapOB8ktB/stap_f29b1e04055fa15fd509a1ac4a2dee7e_3030_src.o] Error 1
make: *** [Makefile:1545: _module_/tmp/stapOB8ktB] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]


Expected results:

compilation succeeds


Additional info:

patch attached
Comment 1 Frank Ch. Eigler 2020-10-22 19:38:49 UTC 
upstream commit 6ecb85fdae111f8949f485566b7192b2858a04fb
we will roll this into the planned 8.4 rebase
Comment 8 errata-xmlrpc 2021-05-18 15:44:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (systemtap bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1829