Can QE try reproducing this issue on RHEL/upstream qemu?

Thanks,
Vadim.

Sorry I have no upstream ENV, tested with following but not reproduce it.

test env:

qemu-kvm-5.1.0-14.module+el8.3.0+8438+644aff69.x86_64


qemu command line:

 /usr/libexec/qemu-kvm \
    -name 'avocado-vt-vm3' \
    -machine q35 \
    -nodefaults \
    -vga std  \
    -device pcie-root-port,port=0x10,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x3 \
    -device pcie-root-port,port=0x11,chassis=2,id=pci.2,bus=pcie.0,addr=0x3.0x1 \
    -device pcie-root-port,port=0x12,chassis=3,id=pci.3,bus=pcie.0,addr=0x3.0x2 \
    -device pcie-root-port,port=0x13,chassis=4,id=pci.4,bus=pcie.0,addr=0x3.0x3 \
    -device pcie-root-port,port=0x14,chassis=5,id=pci.5,bus=pcie.0,addr=0x3.0x4 \
    -device pcie-root-port,port=0x15,chassis=6,id=pci.6,bus=pcie.0,addr=0x3.0x5 \
    -device pcie-root-port,port=0x16,chassis=7,id=pci.7,bus=pcie.0,addr=0x3.0x6 \
    -device pcie-root-port,port=0x17,chassis=8,id=pci.8,bus=pcie.0,addr=0x3.0x7 \
    -drive file=/home/test/win10.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,cache=none -device ide-drive,drive=drive-ide0-0-0,id=ide0-0-0,bus=ide.0,unit=0,bootindex=0 \
    -blockdev node-name=file_stg1,driver=file,cache.direct=on,cache.no-flush=off,filename=/home/test/storage.qcow2,aio=threads \
    -blockdev node-name=drive_stg1,driver=qcow2,cache.direct=on,cache.no-flush=off,file=file_stg1 \
    -device virtio-blk-pci,id=stg1,drive=drive_stg1,bus=pci.8,addr=0x0,logical_block_size=4096,physical_block_size=4096 \
    -device virtio-net-pci,mac=9a:36:83:b6:3d:05,id=idJVpmsF,netdev=id23ZUK6,bus=pci.3  \
    -netdev tap,id=id23ZUK6,vhost=on,script=/etc/qemu-ifup\
    -m 4G  \
    -smp 4,maxcpus=4 \
    -cpu 'Skylake-Server',hv_stimer,hv_synic,hv_vpindex,hv_reset,hv_relaxed,hv_spinlocks=0x1fff,hv_vapic,hv_time,hv-tlbflush,+kvm_pv_unhalt \
    -cdrom /home/kvm_autotest_root/iso/windows/virtio-win-prewhql-0.1-189.iso  \
    -device piix3-usb-uhci,id=usb -device usb-tablet,id=input0 \
    -vnc :11  \
    -rtc base=localtime,clock=host,driftfix=slew  \
    -boot order=cdn,once=c,menu=off,strict=off \
    -enable-kvm \
    -qmp tcp:0:1232,server,nowait \
    -monitor stdio \


I try to search some information， could you try with following to check if that fixes the issue.

1. Open Computer by clicking the Start button, and then clicking Computer.
2. Right-click the drive that you want to check, and then click Properties.
3. Click the Tools tab, and then, under Error-checking, click Check now. If you're prompted for an administrator password or confirmation, type the password or provide confirmation.

To automatically repair problems with files and folders that the scan detects, select Automatically fix file system errors. Otherwise, the disk check will report problems but not fix them.

To perform a thorough check, select Scan for and attempt recovery of bad sectors. This scan attempts to find and repair physical errors on the drive itself, and it can take much longer to complete.

To check for both file errors and physical errors, select both Automatically fix file system errors and Scan for and attempt recovery of bad sectors.

4. Click Start.

Depending on the size of your drive, this might take several minutes. For best results, don't use your computer for any other tasks while it is checking for errors.

Meni, What this command "fsutil fsinfo sectorInfo F:" reports in Windows (replace F with your drive?


Output should be like this:

       LogicalBytesPerSector :                                 4096
       PhysicalBytesPerSectorForAtomicity :                    4096
       PhysicalBytesPerSectorForPerformance :                  4096
       FileSystemEffectivePhysicalBytesPerSectorForAtomicity : 4096
       Device Alignment :                                      Aligned (0x000)
       Partition alignment on device :                         Aligned (0x000)
       Performs Normal Seeks
       Trim Supported

Make sure that "Trim Supported" is shown. 


Next, please run command in PowerShell (change F with your drive):


     Optimize-Volume -DriveLetter F -ReTrim -Verbose


Wait for 10-30 seconds and reboot VM. In case of "raw" format, you should get unavailable disk F.

In case of "qcow2" format, you should see drive corruption during Tool->Error-Checking or during Boot stage (auto filesystem check).

Created attachment 1724137 [details]
driver corruption

Vitaliy, thank you for highlight the checkpoint~

reproduce it on build:

qemu-kvm-core-5.1.0-14.module+el8.3.0+8438+644aff69.x86_64
virtio-win-prewhql-0.1-189.iso


see the drive corruption during Boot stage, but not hit the "raw" format scenario.

correct the qemu command line on comment 2 for miss the discard option

/usr/libexec/qemu-kvm \
    -name 'avocado-vt-vm3' \
    -machine q35 \
    -nodefaults \
    -vga std  \
    -device pcie-root-port,port=0x10,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x3 \
    -device pcie-root-port,port=0x11,chassis=2,id=pci.2,bus=pcie.0,addr=0x3.0x1 \
    -device pcie-root-port,port=0x12,chassis=3,id=pci.3,bus=pcie.0,addr=0x3.0x2 \
    -device pcie-root-port,port=0x13,chassis=4,id=pci.4,bus=pcie.0,addr=0x3.0x3 \
    -device pcie-root-port,port=0x14,chassis=5,id=pci.5,bus=pcie.0,addr=0x3.0x4 \
    -device pcie-root-port,port=0x15,chassis=6,id=pci.6,bus=pcie.0,addr=0x3.0x5 \
    -device pcie-root-port,port=0x16,chassis=7,id=pci.7,bus=pcie.0,addr=0x3.0x6 \
    -device pcie-root-port,port=0x17,chassis=8,id=pci.8,bus=pcie.0,addr=0x3.0x7 \
    -drive file=/home/kvm_autotest_root/images/win10-64-virtio.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,cache=none -device ide-drive,drive=drive-ide0-0-0,id=ide0-0-0,bus=ide.0,unit=0,bootindex=0 \
    -blockdev node-name=file_stg2,driver=file,cache.direct=on,cache.no-flush=off,filename=/home/test/storage.qcow2,aio=threads,discard=unmap \
    -blockdev node-name=drive_stg2,driver=qcow2,cache.direct=on,cache.no-flush=off,file=file_stg2,discard=unmap \
    -device virtio-blk-pci,id=stg2,drive=drive_stg2,bus=pci.4,addr=0x0,logical_block_size=4096,physical_block_size=4096 \
    -device virtio-net-pci,mac=9a:36:83:b6:3d:05,id=idJVpmsF,netdev=id23ZUK6,bus=pci.3  \
    -netdev tap,id=id23ZUK6,vhost=on,script=/etc/qemu-ifup\
    -m 4G  \
    -smp 4,maxcpus=4 \
    -cpu 'Skylake-Server',hv_stimer,hv_synic,hv_vpindex,hv_reset,hv_relaxed,hv_spinlocks=0x1fff,hv_vapic,hv_time,hv-tlbflush,+kvm_pv_unhalt \
    -device piix3-usb-uhci,id=usb -device usb-tablet,id=input0 \
    -vnc :11  \
    -rtc base=localtime,clock=host,driftfix=slew  \
    -boot order=cdn,once=c,menu=off,strict=off \
    -enable-kvm \
    -qmp tcp:0:1232,server,nowait \
    -monitor stdio \


Thanks
Menghuan

Menghuan, to completely loose drive, you should prepare qcow2 disk with the same cluster_size as NTFS block size. 

For instance, I created qcow2 disk with "-o cluster_size=32K", and formatted NTFS with 32K allocation unit size.

After  "Optimize-Volume -DriveLetter G -ReTrim -Verbose" and reboot, drive G was completely lost (I will attach screenshot)

Created attachment 1724138 [details]
Lost disk G: after reboot

Vitaliy, Thank you provide the details.


I try 10 times ,hit one "raw" format scenario, always hit scenario 'see drive corruption during Tool->Error-Checking or during Boot stage' 

1. prepare a qcow2 disk

qemu-img create -f qcow2 storage.qcow2 -o cluster_size=32k  20g

2.formatted NTFS with 32K allocation unit size.

3. boot the guest like comment 6

4.execute  "Optimize-Volume -DriveLetter G -ReTrim -Verbose" in powershell

5.reboot the guest



Thanks

Menghuan

Created attachment 1724153 [details]
raw format scenario

Hi Menghuan,

If you can reproduce the problem with official viostor driver,
could you give a try to this one, available at http://people.redhat.com/vrozenfe/4Vitaliy.zip
and let us know if it helps solveing the problem?
This driver was built aside from the brew build system, and it doesn't have a proper 
version number. So, you might need to uninstall the already installed driver 
first and then install that new one, rather than trying to update viostor driver.

Best,
Vadim.

Use the same qemu command line as comment 6, just install the driver http://people.redhat.com/vrozenfe/4Vitaliy.zip  like comment 11, try 10 times ,not reproduce it.




Thanks

Menghuan

(In reply to menli from comment #12)
> Use the same qemu command line as comment 6, just install the driver
> http://people.redhat.com/vrozenfe/4Vitaliy.zip  like comment 11, try 10
> times ,not reproduce it.
> 
> 
> 
> 
> Thanks
> 
> Menghuan

Thank you, Menghuan.

Please verify with the latest drivers from build 190
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1383208

Reproduce with virtio-win-prewhql-0.1-189.iso version(steps same as comment#0), result is comment 10
Verified with virtio-win-prewhql-0.1-190.iso(steps same as comment#0), no drive corruption
So this issue is fixed, change status to verified.


Thanks 

Menghuan

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:0535