Bug 1891197 - nova-event-callback validation doesn't validate vif_plugging_timeout_check properly
Summary: nova-event-callback validation doesn't validate vif_plugging_timeout_check pr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-validations
Version: 16.1 (Train)
Hardware: All
OS: All
medium
medium
Target Milestone: z3
: 16.1 (Train on RHEL 8.2)
Assignee: Gaël Chamoulaud
QA Contact: nlevinki
URL:
Whiteboard:
: 1867049 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-24 09:38 UTC by Alex Stupnikov
Modified: 2023-12-15 19:54 UTC (History)
7 users (show)

Fixed In Version: openstack-tripleo-validations-11.3.2-1.20200916153436.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-15 18:37:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1901297 0 None None None 2020-10-24 09:39:55 UTC
OpenStack gerrit 759558 0 None MERGED Refactor vif plugging validations 2020-11-24 10:04:30 UTC
Red Hat Product Errata RHEA-2020:5413 0 None None None 2020-12-15 18:37:38 UTC

Description Alex Stupnikov 2020-10-24 09:38:16 UTC
Description of problem:

puppet-nova sets vif_plugging_timeout to 300 seconds by default. In tripleo validations vif_plugging_timeout_value_min is set to 300 seconds [1]

But appropriate check [2] seem to contain a typo: check "Check Nova configuration values" should fail if vif_plugging_timeout_value_min is greater than actual sets vif_plugging_timeout, but actual code tells it to fail if it is greater than or equal.

It looks like a minor bug.

[1]
https://github.com/openstack/tripleo-validations/blob/stable/train/playbooks/nova-event-callback.yaml#L24

[2]
https://github.com/openstack/tripleo-validations/blob/stable/train/roles/nova_event_callback/tasks/main.yml#L19
Version-Release number of selected component (if applicable):

Comment 2 Artom Lifshitz 2020-11-02 17:21:54 UTC
*** Bug 1867049 has been marked as a duplicate of this bug. ***

Comment 12 errata-xmlrpc 2020-12-15 18:37:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.3 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:5413


Note You need to log in before you can comment on or make changes to this bug.