Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1891293

Summary: auto_pinning calculation is broken for hosts with 4 NUMA nodes. request fails
Product: [oVirt] ovirt-engine Reporter: Polina <pagranat>
Component: BLL.VirtAssignee: Liran Rotenberg <lrotenbe>
Status: CLOSED CURRENTRELEASE QA Contact: Polina <pagranat>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4.3.7CC: ahadas, bugs
Target Milestone: ovirt-4.4.4Flags: pm-rhel: ovirt-4.4+
Target Release: 4.4.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.4 Doc Type: Bug Fix
Doc Text:
Previously, when the host hardware had more than 2 NUMA nodes, the engine got out of bound error, preventing from adding that VM. Now, the calculation is fixed and the VM can be added on such hardware when using the auto pinning policy.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-21 12:36:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Polina 2020-10-25 09:46:19 UTC 
Created attachment 1724018 [details]
engine.log

Description of problem: POST https://{{host}}/ovirt-engine/api/vms?auto_pinning_policy=adjust/existing to the host with 4 numa nodes fails


Version-Release number of selected component (if applicable):
ovirt-engine-4.4.3.8-0.1.el8ev.noarch

How reproducible:100%


Steps to Reproduce:
1.POST https://{{host}}/ovirt-engine/api/vms?auto_pinning_policy=adj2020-10-25 10:31:01,036+02 ERROR [org.ovirt.engine.core.bll.AddVmCommand] (default task-2) [] Command 'org.ovirt.engine.core.bll.AddVmCommand' failed: Index 13 out of bounds for length 12
2020-10-25 10:31:01,036+02 ERROR [org.ovirt.engine.core.bll.AddVmCommand] (default task-2) [] Exception: java.lang.ArrayIndexOutOfBoundsException: Index 13 out of bounds for length 12
        at java.base/java.util.Arrays$ArrayList.get(Arrays.java:4351)
ust/existing

to the host with 4 numa nodes, like

available: 4 nodes (0-3)
node 0 cpus: 0 1 2 3 4 5 24 25 26 27 28 29
node 0 size: 15317 MB
node 0 free: 11539 MB
node 1 cpus: 6 7 8 9 10 11 30 31 32 33 34 35
node 1 size: 31010 MB
node 1 free: 24784 MB
node 2 cpus: 12 13 14 15 16 17 36 37 38 39 40 41
node 2 size: 15739 MB
node 2 free: 7775 MB
node 3 cpus: 18 19 20 21 22 23 42 43 44 45 46 47
node 3 size: 31062 MB
node 3 free: 29142 MB

host lscpu - 

CPU(s):              48
On-line CPU(s) list: 0-47
Thread(s) per core:  2
Core(s) per socket:  24
Socket(s):           1
NUMA node(s):        4
Vendor ID:           AuthenticAMD
CPU family:          23
Model:               1

NUMA node0 CPU(s):   0-5,24-29
NUMA node1 CPU(s):   6-11,30-35
NUMA node2 CPU(s):   12-17,36-41
NUMA node3 CPU(s):   18-23,42-47

Actual results:fails

2020-10-25 10:30:55,687+02 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-2) [] EVENT_ID: USER_FAILED_ADD_VM(57), Failed to create VM auto_cpu_vm (User: admin@internal-authz).
2020-10-25 10:30:55,692+02 INFO  [org.ovirt.engine.core.bll.AddVmCommand] (default task-2) [] Lock freed to object 'EngineLock:{exclusiveLocks='[auto_cpu_vm=VM_NAME]', sharedLocks='[0dec0655-5963-49f0-a103-a5e114433645=DISK, 426b8e54-52c7-4f01-b60a-12aaa6870a1a=TEMPLATE]'}'
2020-10-25 10:30:55,692+02 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-2) [] Operation Failed: [Internal Engine Error]
2020-1

2020-10-25 10:31:01,036+02 ERROR [org.ovirt.engine.core.bll.AddVmCommand] (default task-2) [] Command 'org.ovirt.engine.core.bll.AddVmCommand' failed: Index 13 out of bounds for length 12
2020-10-25 10:31:01,036+02 ERROR [org.ovirt.engine.core.bll.AddVmCommand] (default task-2) [] Exception: java.lang.ArrayIndexOutOfBoundsException: Index 13 out of bounds for length 12
        at java.base/java.util.Arrays$ArrayList.get(Arrays.java:4351)


Expected results:success


Additional info: engine log attached
Comment 1 Polina 2020-11-17 11:23:54 UTC 
verified on ovirt-engine-4.4.4-0.1.el8ev.noarch
Comment 2 Sandro Bonazzola 2020-12-21 12:36:20 UTC 
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.