Spec URL: https://salimma.fedorapeople.org/specs/devel/fbthrift.spec SRPM URL: https://salimma.fedorapeople.org/specs/devel/fbthrift-2020.10.26.00-1.fc33.src.rpm Description: Thrift is a serialization and RPC framework for service communication. Thrift enables these features in all major languages, and there is strong support for C++, Python, Hack, and Java. Most services at Facebook are written using Thrift for RPC, and some storage systems use Thrift for serializing records on disk. Facebook Thrift is not a distribution of Apache Thrift. This is an evolved internal branch of Thrift that Facebook re-released to open source community in February 2014. Facebook Thrift was originally released closely tracking Apache Thrift but is now evolving in new directions. In particular, the compiler was rewritten from scratch and the new implementation features a fully asynchronous Thrift server. Fedora Account System Username: salimma
Taking this review.
Initial notes: > Source0: https://github.com/facebook/fbthrift/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz The Source0 URL can be restructured to be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
yeah, that's shorter, why not
updated spec and SRPM (same URL)
Why are you doing "v%{version}.tar.gz#/%{name}-%{version}.tar.gz" instead of "v%{version}/%{name}-%{version}.tar.gz"?
(In reply to Neal Gompa from comment #5) > Why are you doing "v%{version}.tar.gz#/%{name}-%{version}.tar.gz" instead of > "v%{version}/%{name}-%{version}.tar.gz"? It's to rename the source file when downloading. upstream's name is just v%{version}.tar.gz which is not descriptive. everything after the hash basically lets you give the local file a different name
(In reply to Michel Alexandre Salim from comment #6) > (In reply to Neal Gompa from comment #5) > > Why are you doing "v%{version}.tar.gz#/%{name}-%{version}.tar.gz" instead of > > "v%{version}/%{name}-%{version}.tar.gz"? > > It's to rename the source file when downloading. upstream's name is just > v%{version}.tar.gz which is not descriptive. everything after the hash > basically lets you give the local file a different name The URL structure I suggest matches how GitHub actually returns it when you do wget with --content-disposition. It works perfectly with rpmdev-spectool. Give it a shot and try for yourself. :)
(In reply to Neal Gompa from comment #7) > (In reply to Michel Alexandre Salim from comment #6) > > (In reply to Neal Gompa from comment #5) > > > Why are you doing "v%{version}.tar.gz#/%{name}-%{version}.tar.gz" instead of > > > "v%{version}/%{name}-%{version}.tar.gz"? > > > > It's to rename the source file when downloading. upstream's name is just > > v%{version}.tar.gz which is not descriptive. everything after the hash > > basically lets you give the local file a different name > > The URL structure I suggest matches how GitHub actually returns it when you > do wget with --content-disposition. It works perfectly with rpmdev-spectool. > Give it a shot and try for yourself. :) fails for me: $ spectool -gf fbthrift.spec Downloading: https://github.com/facebook/fbthrift/archive/v2020.10.26.00.tar.gz/fbthrift-2020.10.26.00.tar.gz Download failed: 404 Client Error: Not Found for url: https://codeload.github.com/facebook/fbthrift/tar.gz/v2020.10.26.00.tar.gz/fbthrift-2020.10.26.00 - 0.0 B Elapsed Time: -1 day, 17:00:01
Spec URL: https://salimma.fedorapeople.org/specs/devel/fbthrift.spec SRPM URL: https://salimma.fedorapeople.org/specs/devel/fbthrift-2020.10.26.00-2.fc33.src.rpm Had an extra .tar.gz in the URL earlier, works now
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "Expat License", "GNU General Public License, Version 2", "Boost Software License Apache License 2.0", "GNU Lesser General Public License", "Apache License 2.0 [generated file]". 2233 files have unknown license. Detailed output of licensecheck in /home/ngompa/1892101-fbthrift/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/thrift(thrift- devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fbthrift-2020.10.26.00-2.fc34.x86_64.rpm fbthrift-devel-2020.10.26.00-2.fc34.x86_64.rpm fbthrift-debuginfo-2020.10.26.00-2.fc34.x86_64.rpm fbthrift-debugsource-2020.10.26.00-2.fc34.x86_64.rpm fbthrift-2020.10.26.00-2.fc34.src.rpm fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/thrift1 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libasync.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_ast.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.10.26.0 exit.5 fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_base.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_generators.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_lib.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libconcurrency.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libmustache_lib.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libprotocol.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/librpcmetadata.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthrift-core.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftcpp2.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftfrozen2.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftmetadata.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftprotocol.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libtransport.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 5 packages and 0 specfiles checked; 16 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: fbthrift-debuginfo-2020.10.26.00-2.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fbthrift-devel.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift-debugsource.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift-debuginfo.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/thrift1 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libasync.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_ast.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.10.26.0 exit.5 fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_base.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 typeinfo for apache::thrift::compiler::validator fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::visit(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_service*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_enum*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_field*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_const*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_service*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_enum*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_struct*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_field*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_const*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_struct*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 virtual thunk to apache::thrift::compiler::validator::visit(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::add_error(boost::optional<int>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::set_ref_diagnostics(std::vector<apache::thrift::compiler::diagnostic, std::allocator<apache::thrift::compiler::diagnostic> >&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::set_program(apache::thrift::compiler::t_program*) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_generators.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcompiler_lib.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libconcurrency.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libmustache_lib.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libprotocol.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/librpcmetadata.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthrift-core.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftcpp2.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftfrozen2.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftmetadata.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libthriftprotocol.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libtransport.so.2020.10.26.0 ['/usr//usr/lib64'] fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 4 packages and 0 specfiles checked; 16 errors, 85 warnings. Source checksums ---------------- https://github.com/facebook/fbthrift/archive/v2020.10.26.00/fbthrift-2020.10.26.00.tar.gz : CHECKSUM(SHA256) this package : 31427f39d1c0a01e87981d18d22425e98f89a23f6676ad2f74075dafd347d81a CHECKSUM(SHA256) upstream package : 31427f39d1c0a01e87981d18d22425e98f89a23f6676ad2f74075dafd347d81a Requires -------- fbthrift (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libasync.so.2020.10.26.0()(64bit) libboost_context.so.1.73.0()(64bit) libboost_filesystem.so.1.73.0()(64bit) libc.so.6()(64bit) libcompiler_ast.so.2020.10.26.0()(64bit) libcompiler_base.so.2020.10.26.0()(64bit) libcompiler_generators.so.2020.10.26.0()(64bit) libcompiler_lib.so.2020.10.26.0()(64bit) libconcurrency.so.2020.10.26.0()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libdl.so.2()(64bit) libdouble-conversion.so.3()(64bit) libfizz.so.2020.10.26.00()(64bit) libfmt.so.7()(64bit) libfolly.so.2020.10.26.00()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgflags.so.2.2()(64bit) libglog.so.0()(64bit) libmustache_lib.so.2020.10.26.0()(64bit) libprotocol.so.2020.10.26.0()(64bit) libpthread.so.0()(64bit) librpcmetadata.so.2020.10.26.0()(64bit) libssl.so.1.1()(64bit) libssl.so.1.1(OPENSSL_1_1_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libthrift-core.so.2020.10.26.0()(64bit) libthriftmetadata.so.2020.10.26.0()(64bit) libthriftprotocol.so.2020.10.26.0()(64bit) libtransport.so.2020.10.26.0()(64bit) libwangle.so.2020.10.26.00()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) fbthrift-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) fbthrift(x86-64) libasync.so.2020.10.26.0()(64bit) libcompiler_ast.so.2020.10.26.0()(64bit) libcompiler_base.so.2020.10.26.0()(64bit) libcompiler_generators.so.2020.10.26.0()(64bit) libcompiler_lib.so.2020.10.26.0()(64bit) libconcurrency.so.2020.10.26.0()(64bit) libmustache_lib.so.2020.10.26.0()(64bit) libprotocol.so.2020.10.26.0()(64bit) librpcmetadata.so.2020.10.26.0()(64bit) libthrift-core.so.2020.10.26.0()(64bit) libthriftcpp2.so.2020.10.26.0()(64bit) libthriftfrozen2.so.2020.10.26.0()(64bit) libthriftmetadata.so.2020.10.26.0()(64bit) libthriftprotocol.so.2020.10.26.0()(64bit) libtransport.so.2020.10.26.0()(64bit) fbthrift-debuginfo (rpmlib, GLIBC filtered): fbthrift-debugsource (rpmlib, GLIBC filtered): Provides -------- fbthrift: fbthrift fbthrift(x86-64) libasync.so.2020.10.26.0()(64bit) libcompiler_ast.so.2020.10.26.0()(64bit) libcompiler_base.so.2020.10.26.0()(64bit) libcompiler_generators.so.2020.10.26.0()(64bit) libcompiler_lib.so.2020.10.26.0()(64bit) libconcurrency.so.2020.10.26.0()(64bit) libmustache_lib.so.2020.10.26.0()(64bit) libprotocol.so.2020.10.26.0()(64bit) librpcmetadata.so.2020.10.26.0()(64bit) libthrift-core.so.2020.10.26.0()(64bit) libthriftcpp2.so.2020.10.26.0()(64bit) libthriftfrozen2.so.2020.10.26.0()(64bit) libthriftmetadata.so.2020.10.26.0()(64bit) libthriftprotocol.so.2020.10.26.0()(64bit) libtransport.so.2020.10.26.0()(64bit) fbthrift-devel: cmake(FBThrift) cmake(fbthrift) fbthrift-devel fbthrift-devel(x86-64) fbthrift-debuginfo: debuginfo(build-id) fbthrift-debuginfo fbthrift-debuginfo(x86-64) fbthrift-debugsource: fbthrift-debugsource fbthrift-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1892101 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: fonts, R, Perl, Ocaml, PHP, Java, SugarActivity, Python, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Review notes: > [!]: Rpath absent or only used for internal libs. > Note: See rpmlint output There's some cleanup that needs to be done here, the rpath settings are completely superfluous and could cause issues in some circumstances. > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/include/thrift(thrift- > devel) This requires a "Conflicts: thrift-devel" on the devel subpackage. > [!]: Package does not generate any conflict. See above. > [!]: Package should compile and build into binary rpms on all supported > architectures. This is known and documented, so this is fine. > [...] undefined-non-weak-symbol [...] I don't know what's going on here, but something is obviously wrong with how this is getting built...
Spec URL: https://salimma.fedorapeople.org/specs/devel/fbthrift.spec SRPM URL: https://salimma.fedorapeople.org/specs/devel/fbthrift-2020.10.26.00-3.fc33.src.rpm fbthrift-devel now conflicts with thrift-devel, and addressed the RPATH issue. Note: there's a new version of fbthrift out today, but I'm not rebasing yet in case it wouldn't work with the folly/fizz/wangle builds from last week. I'll rebase them all after this is approved. specs on master [!?] ❯ rpmlint /var/lib/mock/fedora-rawhide-x86_64-fbthrift/result/fbthrift-2020.10.26.00-3.fc34.x86_64.rpm fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.10.26.0 exit.5 fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 1 packages and 0 specfiles checked; 0 errors, 3 warnings. (In reply to Neal Gompa from comment #11) > Review notes: > > > [!]: Rpath absent or only used for internal libs. > > Note: See rpmlint output > > There's some cleanup that needs to be done here, the rpath settings are > completely superfluous and could cause issues in some circumstances. > Fixed > > [!]: Package does not own files or directories owned by other packages. > > Note: Dirs in package are owned also by: /usr/include/thrift(thrift- > > devel) > > This requires a "Conflicts: thrift-devel" on the devel subpackage. > > > [!]: Package does not generate any conflict. > > See above. Fixed > > > [...] undefined-non-weak-symbol [...] > > I don't know what's going on here, but something is obviously wrong with how > this is getting built... Turns out to be related to the first RPATH problem. CMakeLists.txt specifies an incorrect RPATH so /usr//usr/lib64 ended up embedded in the shared libraries, which is obviously wrong.
Rpmlint (installed packages) ---------------------------- fbthrift-devel.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift-debuginfo.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift-debugsource.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift.x86_64: W: invalid-url URL: https://github.com/facebook/fbthrift <urlopen error [Errno -3] Temporary failure in name resolution> fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libasync.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.10.26.0 exit.5 fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 typeinfo for apache::thrift::compiler::validator fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::visit(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_service*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_enum*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_field*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_const*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_service*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_enum*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_struct*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_field*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit_and_recurse(apache::thrift::compiler::t_const*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::visitor::visit(apache::thrift::compiler::t_struct*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 virtual thunk to apache::thrift::compiler::validator::visit(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::add_error(boost::optional<int>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::set_ref_diagnostics(std::vector<apache::thrift::compiler::diagnostic, std::allocator<apache::thrift::compiler::diagnostic> >&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcompiler_generators.so.2020.10.26.0 apache::thrift::compiler::validator::set_program(apache::thrift::compiler::t_program*) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libprotocol.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/librpcmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftfrozen2.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::detail::st::translate_field_name(folly::Range<char const*>, short&, apache::thrift::protocol::TType&, apache::thrift::detail::st::translate_field_name_table const&) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::util::detail::throwInvalidVarint() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftmetadata.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwBoolValueOutOfRange(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwExceededSizeLimit() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwUnionMissingStop() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::CompactProtocolReader::throwBadType(unsigned char) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwNegativeSize() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwTruncatedData() fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::CompactProtocolReader::readFieldBeginWithStateMediumSlow(apache::thrift::CompactProtocolReader::StructReadState&, short) fbthrift.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtransport.so.2020.10.26.0 apache::thrift::protocol::TProtocolException::throwInvalidSkipType(apache::thrift::protocol::TType) fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 4 packages and 0 specfiles checked; 0 errors, 85 warnings.
I'm still seeing lots of "undefined-non-weak-symbol" warnings... Are you sure that's RPATH related?
(In reply to Neal Gompa from comment #14) > I'm still seeing lots of "undefined-non-weak-symbol" warnings... Are you > sure that's RPATH related? ah, they only show up if rpmlint is run on an installed package.
Spec URL: https://salimma.fedorapeople.org/specs/devel/fbthrift.spec SRPM URL: https://salimma.fedorapeople.org/specs/devel/fbthrift-2020.11.02.00-1.fc33.src.rpm a lot of targets basically didn't get linked against sufficient libraries. Will be submitting a patch upstream. Note: rebased to 2020.11.02.00 which needs newer dependencies that are all in Rawhide, but you'll need this for Mock to pick them up echo "config_opts['mirrored'] = 0" >> ~/.config/mock.cfg Rpmlint ------- Checking: fbthrift-2020.11.02.00-1.fc34.x86_64.rpm fbthrift-devel-2020.11.02.00-1.fc34.x86_64.rpm fbthrift-debuginfo-2020.11.02.00-1.fc34.x86_64.rpm fbthrift-debugsource-2020.11.02.00-1.fc34.x86_64.rpm fbthrift-2020.11.02.00-1.fc34.src.rpm fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.11.2.0 exit.5 fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 5 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: fbthrift-debuginfo-2020.11.02.00-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.11.2.0 exit.5 fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
Looks good to me now. PACKAGE APPROVED.
Thanks! ❯ fedpkg request-repo fbthrift 1892101 https://pagure.io/releng/fedora-scm-requests/issue/30234
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fbthrift
FEDORA-2020-45065fae47 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-45065fae47
FEDORA-2020-53f08a8053 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-53f08a8053
FEDORA-2020-45065fae47 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-45065fae47 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-45065fae47 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-53f08a8053 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-53f08a8053 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-53f08a8053 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-53f08a8053 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-45065fae47 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.