Bug 1892242 - Wrong snapshot disk href
Summary: Wrong snapshot disk href
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.3.8
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.4.3-1
: ---
Assignee: Ahmad Khiet
QA Contact: Evelina Shames
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-28 09:48 UTC by Evelina Shames
Modified: 2020-11-11 06:39 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-11 06:39:41 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+
aoconnor: blocker+


Attachments (Terms of Use)
logs (1.08 MB, application/zip)
2020-10-28 09:48 UTC, Evelina Shames
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 111808 0 None MERGED restapi: list disk snapshots call under disks resource 2020-11-15 14:51:09 UTC
oVirt gerrit 112024 0 ovirt-engine-4.4.3.z MERGED restapi: list disk snapshots call under disks resource 2020-11-15 14:51:10 UTC

Description Evelina Shames 2020-10-28 09:48:25 UTC
Created attachment 1724743 [details]
logs

Description of problem:
When deleting snapshot disk with rest-api in our automation, the following request is sent:
url:/ovirt-engine/api/storagedomains/c5380b62-443e-4514-866b-da0eb354aa84/disksnapshots/3a0882f1-7071-4b58-9a8d-644890692174/null/ae2aaf18-f971-4963-953e-df7d98e20c3f

while it should be:
url:/ovirt-engine/api/storagedomains/c5380b62-443e-4514-866b-da0eb354aa84/disksnapshots/3a0882f1-7071-4b58-9a8d-644890692174


Art log:
2020-10-28 00:24:13,607 - MainThread - disksnapshots - DEBUG - DELETE request content is --  url:/ovirt-engine/api/storagedomains/c5380b62-443e-4514-866b-da0eb354aa84/disksnapshots/3a0882f1-7071-4b58-9a8d-644890692174/null/ae2aaf18-f971-4963-953e-df7d98e20c3f
2020-10-28 00:24:13,624 - MainThread - core_api - DEBUG - Request DELETE response time: 0.004
2020-10-28 00:24:13,624 - MainThread - disksnapshots - DEBUG - Cleaning Correlation-Id: disksnapshots_delete_95b0a458-a695-4b56
2020-10-28 00:24:13,625 - MainThread - disksnapshots - ERROR - Details was not found on body
2020-10-28 00:24:13,625 - MainThread - api_utils - ERROR - Failed to delete element NOT as expected:
	Status: 404
	Reason: Not Found


Version-Release number of selected component (if applicable):
ovirt-engine-4.4.3.8-0.1.el8ev.noarch


How reproducible:
100% (Automation, didn't try manually yet)

Steps to Reproduce:
1.Send REST-API request for deleting snapshot disk


Actual results:
Operation fails due to wrong url

Expected results:
Operation should succeed with the right url

Additional info:
Logs are attached.

Comment 1 Ahmad Khiet 2020-10-28 10:07:42 UTC
There is a similarity between the path I'm getting while working on https://bugzilla.redhat.com/show_bug.cgi?id=1702237

the link with 'null' and the rest of the path after the 'null' is the same exact issue I'm facing while adding the disk snapshots under disks

<disk_snapshots>
<disk_snapshot href="/ovirt-engine/api/storagedomains/141f33b0-426e-4a6a-8eb6-5c1632ed97b9/disksnapshots/a6385287-dfe1-4e63-8145-fe25dd365fe5/null/1f57e636-c8d8-4732-80d2-0a3ae7305f04" id="1f57e636-c8d8-4732-80d2-0a3ae7305f04">
<name>testVm1_Disk1</name>
<description/>
<actual_size>200704</actual_size>
<alias>testVm1_Disk1</alias>
<backup>none</backup>
<content_type>data</content_type>
<format>cow</format>
<propagate_errors>false</propagate_errors>
<provisioned_size>1073741824</provisioned_size>
<qcow_version>qcow2_v3</qcow_version>
<shareable>false</shareable>
<sparse>true</sparse>
<status>ok</status>
<storage_type>image</storage_type>
<total_size>0</total_size>
<wipe_after_delete>false</wipe_after_delete>
<disk_profile href="/ovirt-engine/api/diskprofiles/7bb39463-50c3-4a2e-99e1-7d5a7b67b758" id="7bb39463-50c3-4a2e-99e1-7d5a7b67b758"/>
<quota href="/ovirt-engine/api/datacenters/3ac5918e-cbff-11ea-b1ee-54e1ad661a6c/quotas/3ee9ee18-cbff-11ea-b519-54e1ad661a6c" id="3ee9ee18-cbff-11ea-b519-54e1ad661a6c"/>
<snapshot id="9251a1db-ca60-4920-8c4c-8713394b24a8"/>
<storage_domains>
<storage_domain href="/ovirt-engine/api/storagedomains/141f33b0-426e-4a6a-8eb6-5c1632ed97b9" id="141f33b0-426e-4a6a-8eb6-5c1632ed97b9"/>
</storage_domains>
<disk href="/ovirt-engine/api/disks/236593ad-0042-4f3a-bcbb-deef100912db" id="236593ad-0042-4f3a-bcbb-deef100912db"/>
<parent href="/ovirt-engine/api/storagedomains/141f33b0-426e-4a6a-8eb6-5c1632ed97b9/disksnapshots/a6385287-dfe1-4e63-8145-fe25dd365fe5" id="a6385287-dfe1-4e63-8145-fe25dd365fe5"/>
</disk_snapshot>
....
..

Comment 2 Avihai 2020-10-28 10:45:44 UTC
Added severity as high as this is a basic functionality flow(delete snapshot disk) and also automation blocker as it fails multiple Tier2 and Tier3 TC's.

Comment 3 Evelina Shames 2020-10-28 11:58:34 UTC
Added a Regression keyword as it worked till ovirt-engine-4.4.3.8-0.1.el8ev.noarch

We had tests of deleting snapshot disks that failed before due to bug 1702237, but as Ahmad mentioned, it is not related to this bug and it is something new that appears in this version.

Comment 4 RHEL Program Management 2020-10-28 13:07:34 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 5 Evelina Shames 2020-11-04 13:16:24 UTC
Verified on rhv-4.4.3-13

Comment 6 Evelina Shames 2020-11-04 13:30:20 UTC
(In reply to Evelina Shames from comment #5)
> Verified on rhv-4.4.3-13

Just to make it clear, delete snapshot disk still doesn't work because of bug 1702237.
What was verified it that now the right URL appears, without .../null/...

Comment 7 Evelina Shames 2020-11-05 17:54:05 UTC
(In reply to Evelina Shames from comment #6)
> (In reply to Evelina Shames from comment #5)
> > Verified on rhv-4.4.3-13
> 
> Just to make it clear, delete snapshot disk still doesn't work because of
> bug 1702237.
> What was verified it that now the right URL appears, without .../null/...

Accidentally verified on the wrong environment.

Verified again on rhv-4.4.3-13:

href is as expected:
/ovirt-engine/api/storagedomains/249e24db-4263-48cd-9dd7-5448afe6f75f/disksnapshots/15a68720-6b7f-482b-b61c-ae4c9d9bab9d

Delete snapshot disk operation succeeded.

Comment 8 Sandro Bonazzola 2020-11-11 06:39:41 UTC
This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.